From: Or Gerlitz <gerlitz.or@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net/sched: cls_flower: Set egress_dev mark when calling into the HW driver
Date: Wed, 18 Oct 2017 10:14:48 +0300 [thread overview]
Message-ID: <CAJ3xEMjWCL3kSvfenCaLYnbvmGfyS2-zig7MhVMa1+oUMCLpbA@mail.gmail.com> (raw)
In-Reply-To: <1a523077-3c05-ba97-8a65-1967765b8d5a@cogentembedded.com>
On Tue, Oct 17, 2017 at 2:29 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello!
>
> On 10/16/2017 12:19 PM, Or Gerlitz wrote:
>
>> Commit 7091d8c '(net/sched: cls_flower: Add offload support using egress
>
>
> At least 12 digits are needed.
Also on such a spot (e.g not on the Fixes line)?
>
>> Hardware device') made sure (when fl_hw_replace_filter is called) to put
>> the egress_dev mark on persisent structure instance. Hence, following
>> calls
> Persistent.
right
>> into the HW driver for stats and deletion will note it and act
>> accordingly.
>> With commit de4784ca030f this property is lost and hence when called,
>> the HW driver failes to operate (stats, delete) on the offloaded flow.
> Fails.
correct
This is applied, will take more care next time
next prev parent reply other threads:[~2017-10-18 7:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 9:19 [PATCH net] net/sched: cls_flower: Set egress_dev mark when calling into the HW driver Or Gerlitz
2017-10-16 12:41 ` Jiri Pirko
2017-10-16 20:20 ` David Miller
2017-10-17 11:29 ` Sergei Shtylyov
2017-10-18 7:14 ` Or Gerlitz [this message]
2017-10-18 8:09 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3xEMjWCL3kSvfenCaLYnbvmGfyS2-zig7MhVMa1+oUMCLpbA@mail.gmail.com \
--to=gerlitz.or@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).