Information about SCTP patch

Information about SCTP patch

[kishan simha]

Hello,

I wanted some information on the SCTP patch   "sctp: Add support to
per-association statistics via a new SCTP_GET_ASSOC_STA "


The commit information is

commit 196d67593439b03088913227093e374235596e33

Author: Michele Baldessari <michele@acksyn.org>

Date:   Sat Dec 1 04:49:42 2012 +0000


Is it possible to know into which kernel version did this patch go into?
I tried to find it online and I was not able to. Hence mailing to this list.

It will be helpful if you anyone answer this.

Thanks and Regards
Kishan

Re: Information about SCTP patch

[Eric Dumazet]

On Thu, 2014-06-26 at 12:58 +0530, kishan simha wrote:
> Hello,
> 
> I wanted some information on the SCTP patch   "sctp: Add support to
> per-association statistics via a new SCTP_GET_ASSOC_STA "
> 
> 
> The commit information is
> 
> commit 196d67593439b03088913227093e374235596e33
> 
> Author: Michele Baldessari <michele@acksyn.org>
> 
> Date:   Sat Dec 1 04:49:42 2012 +0000
> 
> 
> Is it possible to know into which kernel version did this patch go into?
> I tried to find it online and I was not able to. Hence mailing to this list.
> 
> It will be helpful if you anyone answer this.

Sure :

$ git describe --contains 196d67593439b03088913227093e374235596e33

v3.8-rc1~139^2~117


So all linux versions starting from linux-3.8 have it.

Re: Information about SCTP patch

[Michele Baldessari]

Hi Kishan,

On Thu, Jun 26, 2014 at 12:58:54PM +0530, kishan simha wrote:
> I wanted some information on the SCTP patch   "sctp: Add support to
> per-association statistics via a new SCTP_GET_ASSOC_STA "
> 
> The commit information is
> commit 196d67593439b03088913227093e374235596e33
> Author: Michele Baldessari <michele@acksyn.org>
> Date:   Sat Dec 1 04:49:42 2012 +0000
> 
> Is it possible to know into which kernel version did this patch go into?
> I tried to find it online and I was not able to. Hence mailing to this list.

as Eric mentioned, it's in 3.8 (or also in RHEL-6.5). Feel free to reach out
if you have any questions.

cheers,
Michele
-- 
Michele Baldessari            <michele@acksyn.org>
C2A5 9DA3 9961 4FFB E01B  D0BC DDD4 DCCB 7515 5C6D

Re: Information about SCTP patch

[kishan simha]

Hello Michele,

Thank you for the response.

I have a few more queries regarding the patch.

We are trying to integrate this patch to a little older kernel 2.6.34.13.
Additionally we are planning to give a proc file interface to display the stats.

I came across a review comment for your patch, where the proc solution
was rejected.

Can you provide some information on why the solution was rejected ?

Thanks and Regards
Kishan



On Sat, Jun 28, 2014 at 1:36 AM, Michele Baldessari <michele@acksyn.org> wrote:
> Hi Kishan,
>
> On Thu, Jun 26, 2014 at 12:58:54PM +0530, kishan simha wrote:
>> I wanted some information on the SCTP patch   "sctp: Add support to
>> per-association statistics via a new SCTP_GET_ASSOC_STA "
>>
>> The commit information is
>> commit 196d67593439b03088913227093e374235596e33
>> Author: Michele Baldessari <michele@acksyn.org>
>> Date:   Sat Dec 1 04:49:42 2012 +0000
>>
>> Is it possible to know into which kernel version did this patch go into?
>> I tried to find it online and I was not able to. Hence mailing to this list.
>
> as Eric mentioned, it's in 3.8 (or also in RHEL-6.5). Feel free to reach out
> if you have any questions.
>
> cheers,
> Michele
> --
> Michele Baldessari            <michele@acksyn.org>
> C2A5 9DA3 9961 4FFB E01B  D0BC DDD4 DCCB 7515 5C6D

Re: Information about SCTP patch

[Michele Baldessari]

Hi Kishan,

On Mon, Jul 21, 2014 at 02:08:21PM +0530, kishan simha wrote:
> We are trying to integrate this patch to a little older kernel 2.6.34.13.

This is trivial as we've done so for RHEL 6.5 already.

> Additionally we are planning to give a proc file interface to display the stats.
> 
> I came across a review comment for your patch, where the proc solution
> was rejected.
> 
> Can you provide some information on why the solution was rejected ?

It was preferred to do it via an API extension, similar to how
Solaris does it. And, I believe, the /proc interface for these kind of
things is discouraged.

regards,
Michele
-- 
Michele Baldessari            <michele@acksyn.org>
C2A5 9DA3 9961 4FFB E01B  D0BC DDD4 DCCB 7515 5C6D

RE: Information about SCTP patch

[Padiyar, Prasad (NSN - IN/Bangalore)]

Hi Michele,

Thanks for your time and reply.

We here have a requirement to implement a CLI to get these stats.
And one of the options we thought to use was /proc files to get these stats.

Going through the mail chain of this patch (http://www.spinics.net/lists/linux-sctp/msg01813.html) , I came across this.
" socket option is preferable as /proc doesn't scale very well as number of associations grows."


Here I am just curious to know how much "is the number of associations" referred to?


Thanks & Regards,
Prasad 

-----Original Message-----
From: ext Michele Baldessari [mailto:michele@acksyn.org] 
Sent: Tuesday, July 22, 2014 1:33 PM
To: kishan simha
Cc: linux-sctp@vger.kernel.org; netdev@vger.kernel.org; Padiyar, Prasad (NSN - IN/Bangalore); Kumar, Sumit 11. (NSN - IN/Bangalore)
Subject: Re: Information about SCTP patch

Hi Kishan,

On Mon, Jul 21, 2014 at 02:08:21PM +0530, kishan simha wrote:
> We are trying to integrate this patch to a little older kernel 2.6.34.13.

This is trivial as we've done so for RHEL 6.5 already.

> Additionally we are planning to give a proc file interface to display the stats.
> 
> I came across a review comment for your patch, where the proc solution
> was rejected.
> 
> Can you provide some information on why the solution was rejected ?

It was preferred to do it via an API extension, similar to how
Solaris does it. And, I believe, the /proc interface for these kind of
things is discouraged.

regards,
Michele
-- 
Michele Baldessari            <michele@acksyn.org>
C2A5 9DA3 9961 4FFB E01B  D0BC DDD4 DCCB 7515 5C6D