* [PATCH] selftests/bpf: Upon failures, exit with code 1 in test_xsk.sh
@ 2025-08-28 18:48 Ricardo B. Marlière
2025-08-29 7:09 ` Magnus Karlsson
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo B. Marlière @ 2025-08-28 18:48 UTC (permalink / raw)
To: Björn Töpel, Magnus Karlsson, Maciej Fijalkowski,
Jonathan Lemon, Stanislav Fomichev, Andrii Nakryiko,
Eduard Zingerman, Mykola Lysenko, Alexei Starovoitov,
Daniel Borkmann, Martin KaFai Lau, Song Liu, Yonghong Song,
John Fastabend, KP Singh, Hao Luo, Jiri Olsa, Shuah Khan
Cc: netdev, bpf, linux-kselftest, linux-kernel,
Ricardo B. Marlière
Currently, even if some subtests fails, the end result will still yield
"ok 1 selftests: bpf: test_xsk.sh". Fix it by exiting with 1 if there are
any failures.
Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
---
tools/testing/selftests/bpf/test_xsk.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh
index 65aafe0003db054e9dfd156092fed53b07be06a0..62db060298a4a3b4391ee4cfa50557cf4a62d3d5 100755
--- a/tools/testing/selftests/bpf/test_xsk.sh
+++ b/tools/testing/selftests/bpf/test_xsk.sh
@@ -241,4 +241,6 @@ done
if [ $failures -eq 0 ]; then
echo "All tests successful!"
+else
+ exit 1
fi
---
base-commit: 5b6d6fe1ca7b712c74f78426bb23c465fd34b322
change-id: 20250828-selftests-bpf-test_xsk_ret-1eb27dbac071
Best regards,
--
Ricardo B. Marlière <rbm@suse.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/bpf: Upon failures, exit with code 1 in test_xsk.sh
2025-08-28 18:48 [PATCH] selftests/bpf: Upon failures, exit with code 1 in test_xsk.sh Ricardo B. Marlière
@ 2025-08-29 7:09 ` Magnus Karlsson
0 siblings, 0 replies; 2+ messages in thread
From: Magnus Karlsson @ 2025-08-29 7:09 UTC (permalink / raw)
To: Ricardo B. Marlière
Cc: Björn Töpel, Magnus Karlsson, Maciej Fijalkowski,
Jonathan Lemon, Stanislav Fomichev, Andrii Nakryiko,
Eduard Zingerman, Mykola Lysenko, Alexei Starovoitov,
Daniel Borkmann, Martin KaFai Lau, Song Liu, Yonghong Song,
John Fastabend, KP Singh, Hao Luo, Jiri Olsa, Shuah Khan, netdev,
bpf, linux-kselftest, linux-kernel
On Thu, 28 Aug 2025 at 20:48, Ricardo B. Marlière <rbm@suse.com> wrote:
>
> Currently, even if some subtests fails, the end result will still yield
> "ok 1 selftests: bpf: test_xsk.sh". Fix it by exiting with 1 if there are
> any failures.
>
> Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
Thanks Ricardo.
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> tools/testing/selftests/bpf/test_xsk.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh
> index 65aafe0003db054e9dfd156092fed53b07be06a0..62db060298a4a3b4391ee4cfa50557cf4a62d3d5 100755
> --- a/tools/testing/selftests/bpf/test_xsk.sh
> +++ b/tools/testing/selftests/bpf/test_xsk.sh
> @@ -241,4 +241,6 @@ done
>
> if [ $failures -eq 0 ]; then
> echo "All tests successful!"
> +else
> + exit 1
> fi
>
> ---
> base-commit: 5b6d6fe1ca7b712c74f78426bb23c465fd34b322
> change-id: 20250828-selftests-bpf-test_xsk_ret-1eb27dbac071
>
> Best regards,
> --
> Ricardo B. Marlière <rbm@suse.com>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-29 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-28 18:48 [PATCH] selftests/bpf: Upon failures, exit with code 1 in test_xsk.sh Ricardo B. Marlière
2025-08-29 7:09 ` Magnus Karlsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).