netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] ipv6: fix the debug information in icmpv6_route_lookup
@ 2014-07-11  6:34 roy.qing.li
  2014-07-11  6:45 ` YOSHIFUJI Hideaki
  0 siblings, 1 reply; 3+ messages in thread
From: roy.qing.li @ 2014-07-11  6:34 UTC (permalink / raw)
  To: netdev

From: Li RongQing <roy.qing.li@gmail.com>

it should be "anycast destination", not "anycast source"

Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
 net/ipv6/icmp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
index f6c84a6..481fd5a 100644
--- a/net/ipv6/icmp.c
+++ b/net/ipv6/icmp.c
@@ -334,7 +334,7 @@ static struct dst_entry *icmpv6_route_lookup(struct net *net,
 	 * anycast.
 	 */
 	if (((struct rt6_info *)dst)->rt6i_flags & RTF_ANYCAST) {
-		LIMIT_NETDEBUG(KERN_DEBUG "icmp6_send: acast source\n");
+		LIMIT_NETDEBUG(KERN_DEBUG "icmp6_send: acast destination\n");
 		dst_release(dst);
 		return ERR_PTR(-EINVAL);
 	}
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] ipv6: fix the debug information in icmpv6_route_lookup
  2014-07-11  6:34 [PATCH net-next] ipv6: fix the debug information in icmpv6_route_lookup roy.qing.li
@ 2014-07-11  6:45 ` YOSHIFUJI Hideaki
  2014-07-11  6:51   ` Li RongQing
  0 siblings, 1 reply; 3+ messages in thread
From: YOSHIFUJI Hideaki @ 2014-07-11  6:45 UTC (permalink / raw)
  To: roy.qing.li, netdev; +Cc: hideaki.yoshifuji

Hi,

roy.qing.li@gmail.com wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
> 
> it should be "anycast destination", not "anycast source"
> 
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> ---
>   net/ipv6/icmp.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
> index f6c84a6..481fd5a 100644
> --- a/net/ipv6/icmp.c
> +++ b/net/ipv6/icmp.c
> @@ -334,7 +334,7 @@ static struct dst_entry *icmpv6_route_lookup(struct net *net,
>   	 * anycast.
>   	 */
>   	if (((struct rt6_info *)dst)->rt6i_flags & RTF_ANYCAST) {
> -		LIMIT_NETDEBUG(KERN_DEBUG "icmp6_send: acast source\n");
> +		LIMIT_NETDEBUG(KERN_DEBUG "icmp6_send: acast destination\n");
>   		dst_release(dst);
>   		return ERR_PTR(-EINVAL);
>   	}
> 

No.
It is used by icmp6_send() and it means icmp6_send() won't
send back to the original "anycast" source addresses.

--yoshfuji

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] ipv6: fix the debug information in icmpv6_route_lookup
  2014-07-11  6:45 ` YOSHIFUJI Hideaki
@ 2014-07-11  6:51   ` Li RongQing
  0 siblings, 0 replies; 3+ messages in thread
From: Li RongQing @ 2014-07-11  6:51 UTC (permalink / raw)
  To: YOSHIFUJI Hideaki; +Cc: netdev

On Fri, Jul 11, 2014 at 2:45 PM, YOSHIFUJI Hideaki
<hideaki.yoshifuji@miraclelinux.com> wrote:
> No.
> It is used by icmp6_send() and it means icmp6_send() won't
> send back to the original "anycast" source addresses.


Ok, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-07-11  6:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-11  6:34 [PATCH net-next] ipv6: fix the debug information in icmpv6_route_lookup roy.qing.li
2014-07-11  6:45 ` YOSHIFUJI Hideaki
2014-07-11  6:51   ` Li RongQing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).