From: Li RongQing <roy.qing.li@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH][net-next] net: avoid to call skb_queue_len again
Date: Mon, 8 Dec 2014 08:46:47 +0800 [thread overview]
Message-ID: <CAJFZqHzeESfMBqb1gQr4DsE-v_fSfUX+AyWbt_VriJJ8Dj2FnA@mail.gmail.com> (raw)
In-Reply-To: <1417789870.15618.1.camel@edumazet-glaptop2.roam.corp.google.com>
On Fri, Dec 5, 2014 at 10:31 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Fri, 2014-12-05 at 17:06 +0300, Sergei Shtylyov wrote:
>> Hello.
>>
>> On 12/5/2014 12:49 PM, roy.qing.li@gmail.com wrote:
>>
>> > From: Li RongQing <roy.qing.li@gmail.com>
>>
>> > the queue length of sd->input_pkt_queue has been putted into qlen,
>>
>> s/putted/put/, it's irregular verb.
>>
I will fix it and resend this patch
>> > and impossible to change, since hold the lock
>>
>> I can't parse that. Who holds the lock?
>
> This thread/cpu holds the lock to manipulate input_pkt_queue.
>
> Otherwise, the following would break horribly....
>
> __skb_queue_tail(&sd->input_pkt_queue, skb);
>
>
Thanks Eric
-Roy
>
next prev parent reply other threads:[~2014-12-08 0:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 9:49 [PATCH][net-next] net: avoid to call skb_queue_len again roy.qing.li
2014-12-05 13:24 ` Eric Dumazet
2014-12-05 14:06 ` Sergei Shtylyov
2014-12-05 14:31 ` Eric Dumazet
2014-12-08 0:46 ` Li RongQing [this message]
2014-12-08 11:28 ` Sergei Shtylyov
2014-12-08 15:10 ` Eric Dumazet
2014-12-08 16:51 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFZqHzeESfMBqb1gQr4DsE-v_fSfUX+AyWbt_VriJJ8Dj2FnA@mail.gmail.com \
--to=roy.qing.li@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).