netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hadar Hen Zion <hadarh@dev.mellanox.co.il>
To: tom@herbertland.com, Jiri Pirko <jiri@mellanox.com>
Cc: Amir Vadai <amirva@gmail.com>, Or Gerlitz <ogerlitz@mellanox.com>,
	netdev <netdev@vger.kernel.org>
Subject: flow_dissector: Get vlan priority in addition to vlan id
Date: Sun, 7 Aug 2016 10:43:25 +0300	[thread overview]
Message-ID: <CAJL1qvGt_QwecHfPMvkr54=uT8OBZ88DMmn5E=BQRpUWY6aHKw@mail.gmail.com> (raw)

Hi Tom and Jiri,

I would like to add vlan priority to  __skb_flow_dissect.

In the current vlan tag implementation there isn't any room left to
vlan priority next to the vlan id.

struct flow_dissector_key_tags {
                u32         vlan_id:12,
                                flow_label:20;
};

According to the discussion between you two [1], I'll be happy to get
your advice about what is the best way of adding vlan priority?

My suggestion is to add new vlan tag struct, it will make the code
cleaner and since we have to add 3 bits to vlan priority any way it
won't add unnecessary physical address holes.

struct flow_dissector_key_tags {
                u32         flow_label:20;
};

struct flow_dissector_key_vlan {
                u16         vlan_id:12,
                                vlan_priority:3;
};

Thanks,
Hadar

[1] - http://marc.info/?l=linux-netdev&m=143232557025994&w=2

                 reply	other threads:[~2016-08-07  7:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJL1qvGt_QwecHfPMvkr54=uT8OBZ88DMmn5E=BQRpUWY6aHKw@mail.gmail.com' \
    --to=hadarh@dev.mellanox.co.il \
    --cc=amirva@gmail.com \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).