netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* flow_dissector: Get vlan priority in addition to vlan id
@ 2016-08-07  7:43 Hadar Hen Zion
  0 siblings, 0 replies; only message in thread
From: Hadar Hen Zion @ 2016-08-07  7:43 UTC (permalink / raw)
  To: tom, Jiri Pirko; +Cc: Amir Vadai, Or Gerlitz, netdev

Hi Tom and Jiri,

I would like to add vlan priority to  __skb_flow_dissect.

In the current vlan tag implementation there isn't any room left to
vlan priority next to the vlan id.

struct flow_dissector_key_tags {
                u32         vlan_id:12,
                                flow_label:20;
};

According to the discussion between you two [1], I'll be happy to get
your advice about what is the best way of adding vlan priority?

My suggestion is to add new vlan tag struct, it will make the code
cleaner and since we have to add 3 bits to vlan priority any way it
won't add unnecessary physical address holes.

struct flow_dissector_key_tags {
                u32         flow_label:20;
};

struct flow_dissector_key_vlan {
                u16         vlan_id:12,
                                vlan_priority:3;
};

Thanks,
Hadar

[1] - http://marc.info/?l=linux-netdev&m=143232557025994&w=2

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-07  7:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-07  7:43 flow_dissector: Get vlan priority in addition to vlan id Hadar Hen Zion

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).