From: Stefan Hajnoczi <stefanha@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: sonnyrao@chromium.org, netdev@vger.kernel.org
Subject: Re: [v2] vhost: add vsock compat ioctl
Date: Thu, 22 Mar 2018 09:25:35 +0000 [thread overview]
Message-ID: <CAJSP0QUFjhq-X=vRH+qb0XPRm5daqWqouwHJf1Lo_sHhjD7vQg@mail.gmail.com> (raw)
In-Reply-To: <20180316.153018.1513048030981683655.davem@davemloft.net>
On Fri, Mar 16, 2018 at 7:30 PM, David Miller <davem@davemloft.net> wrote:
> Although the top level ioctls are probably size and layout compatible,
> I do not think that the deeper ioctls can be called by compat binaries
> without some translations in order for them to work.
I audited the vhost ioctl code when reviewing this patch and was
unable to find anything that would break for a 32-bit userspace
process.
drivers/vhost/net.c does the same thing already, which doesn't prove
it's correct but makes me more confident I didn't miss something while
auditing the vhost ioctl code.
Did you have a specific ioctl in mind?
Stefan
next prev parent reply other threads:[~2018-03-22 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 19:30 [v2] vhost: add vsock compat ioctl David Miller
2018-03-17 0:54 ` Sonny Rao
2018-03-17 13:24 ` David Miller
2018-03-22 9:25 ` Stefan Hajnoczi [this message]
2018-03-22 20:38 ` Sonny Rao
2018-03-25 20:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QUFjhq-X=vRH+qb0XPRm5daqWqouwHJf1Lo_sHhjD7vQg@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sonnyrao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).