From: Or Gerlitz <or.gerlitz@gmail.com>
To: Wei Yang <weiyang@linux.vnet.ibm.com>
Cc: Or Gerlitz <ogerlitz@mellanox.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Amir Vadai <amirv@mellanox.com>,
Jack Morgenstein <jackm@dev.mellanox.co.il>
Subject: Re: [PATCH 3.14-stable] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one()
Date: Tue, 3 Jun 2014 11:43:05 +0300 [thread overview]
Message-ID: <CAJZOPZJLwJrsEDMeJVmdJ3ykJWQJjSthYOTCPCrWOTws-Wta-Q@mail.gmail.com> (raw)
In-Reply-To: <20140602135334.GA28523@richard>
On Mon, Jun 2, 2014 at 4:53 PM, Wei Yang <weiyang@linux.vnet.ibm.com> >
> Thanks for your notification, I saw your patch to fix this issue.
> Sorry for bringing a bug in the driver and thanks for your test :-)
sure
> Hmm... actually I don't understand how you trigger this crash?
1. load the driver with num_vfs = (say) four and probe_vf (say) = two
2. reboot
[...]
> Last but not the least, based on the fix you have submitted, the porting here
> is correct. My suggestion is after your fix is merged, you could do the
> porting to those version too.
As I wrote in the other thread to Bjorn, we're practically OOO for the
rest of this week, and anyway, I suggest we 1st see what ends up
happening with the fix to the regression introduced by your commit and
take it from there.
next prev parent reply other threads:[~2014-06-03 8:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 7:24 [PATCH 3.14-stable] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one() Wei Yang
2014-06-01 7:38 ` Wei Yang
2014-06-01 9:30 ` Or Gerlitz
2014-06-01 9:36 ` Or Gerlitz
2014-06-01 10:52 ` Or Gerlitz
2014-06-02 13:53 ` Wei Yang
2014-06-03 8:43 ` Or Gerlitz [this message]
2014-06-04 1:44 ` Wei Yang
2014-06-17 2:49 ` Wei Yang
2014-06-17 3:03 ` David Miller
2014-06-17 3:08 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZOPZJLwJrsEDMeJVmdJ3ykJWQJjSthYOTCPCrWOTws-Wta-Q@mail.gmail.com \
--to=or.gerlitz@gmail.com \
--cc=amirv@mellanox.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=jackm@dev.mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).