From: Or Gerlitz <or.gerlitz@gmail.com>
To: Veaceslav Falico <vfalico@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Eyal Perry <eyalpe@mellanox.com>
Subject: Re: [PATCH net-next 2/2] bonding: remove alb_set_mac_address()
Date: Thu, 22 May 2014 17:36:19 +0300 [thread overview]
Message-ID: <CAJZOPZKHm_0zpHQWSVrkcs4YsRbYSTWj1DU7SMG6PHHCeZcb3Q@mail.gmail.com> (raw)
In-Reply-To: <1400764324-23221-3-git-send-email-vfalico@gmail.com>
On Thu, May 22, 2014 at 4:12 PM, Veaceslav Falico <vfalico@gmail.com> wrote:
>
> Currently it's called only from bond_alb_set_mac_address(), which is called
> only for ALB mode, and it does nothing in case the mode is ALB. So,
> basically, it's a no-op. All the needed functionality (modifying the active
> slave's mac address, per example) is handled by the
> bond_alb_set_mac_address() itself.
So with this patch @ hand, no more touching of the underlying device
dev_addr field directly -- or we still have more accesses of this
such, e.g in bond_alb_set_mac_address() and/or friends?
Or.
next prev parent reply other threads:[~2014-05-22 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 13:12 [PATCH net-next 0/2] bonding: remove rlb_enabled and alb_set_mac_address() Veaceslav Falico
2014-05-22 13:12 ` [PATCH net-next 1/2] bonding: remove rlb_enabled and use mode == ALB instead Veaceslav Falico
2014-05-22 13:12 ` [PATCH net-next 2/2] bonding: remove alb_set_mac_address() Veaceslav Falico
2014-05-22 14:36 ` Or Gerlitz [this message]
2014-05-22 14:57 ` Veaceslav Falico
2014-05-23 6:38 ` Or Gerlitz
2014-05-22 15:28 ` Vlad Yasevich
2014-05-22 15:56 ` Veaceslav Falico
2014-05-22 18:37 ` Jay Vosburgh
2014-05-22 21:22 ` [PATCH net-next 0/2] bonding: remove rlb_enabled and alb_set_mac_address() David Miller
2014-07-06 13:56 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZOPZKHm_0zpHQWSVrkcs4YsRbYSTWj1DU7SMG6PHHCeZcb3Q@mail.gmail.com \
--to=or.gerlitz@gmail.com \
--cc=andy@greyhouse.net \
--cc=eyalpe@mellanox.com \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).