From: Or Gerlitz <or.gerlitz@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Roland Dreier <roland@kernel.org>,
Amir Vadai <amirv@mellanox.com>,
Eli Cohen <eli@dev.mellanox.co.il>,
Or Gerlitz <ogerlitz@mellanox.com>,
Eugenia Emantayev <eugenia@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
Mel Gorman <mgorman@suse.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP
Date: Wed, 26 Feb 2014 23:18:50 +0200 [thread overview]
Message-ID: <CAJZOPZKLcFC5Wqv7VS7AyovaeHw3PYSWEz9t9sZ4AMhG+dS1+A@mail.gmail.com> (raw)
On Wed, Feb 26, 2014 at 12:55 AM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Wed, 26 Feb 2014, Or Gerlitz wrote:
[...]
> That definitely can be verified, and I am putting it on my TODO list.
OK, thanks
> But let's make sure that we don't diverge from the original problem too
> much. Simple fact is that the deadlock is there when using connected mode,
> and there is nothing preventing users from using it this way, therefore I
> believe it should be fixed one way or another.
the patch is titled with "mlx4:" -- do you expect the problem to come
into play only when ipoib connected mode runs over the mlx4 driver?
what's about mlx5 or other upstream IB drivers?
I'll be looking on the details of the problem/solution, but this way
or another the API being module param sounds more like a hack....
Do we have a way to tell a net-device instance they should do their
memory allocations in a NOFS manner? if not, shouldn't we come up with
more general injection method?
next reply other threads:[~2014-02-26 21:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 21:18 Or Gerlitz [this message]
2014-02-27 9:48 ` [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP Jiri Kosina
2014-02-27 9:58 ` Or Gerlitz
2014-02-27 10:42 ` Jiri Kosina
2014-03-04 22:48 ` Jiri Kosina
2014-03-05 15:57 ` Or Gerlitz
2014-03-05 19:25 ` Roland Dreier
2014-03-11 13:53 ` Or Gerlitz
2014-03-14 19:50 ` Jiri Kosina
2014-04-24 17:03 ` Jiri Kosina
2014-04-24 20:01 ` Or Gerlitz
2014-05-02 13:03 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2014-02-21 21:53 Jiri Kosina
[not found] ` <CAJZOPZK4Ah+nKPWnX3=yM43jbf586GYJ+fh0-OL4bOnqKK8v8A@mail.gmail.com>
2014-02-25 21:52 ` Or Gerlitz
2014-02-25 22:11 ` Jiri Kosina
2014-02-25 22:20 ` Or Gerlitz
2014-02-25 22:40 ` Jiri Kosina
2014-02-25 22:48 ` Or Gerlitz
2014-02-25 22:55 ` Jiri Kosina
2014-03-05 19:46 ` Or Gerlitz
2014-03-06 13:31 ` Or Gerlitz
2014-03-06 13:47 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZOPZKLcFC5Wqv7VS7AyovaeHw3PYSWEz9t9sZ4AMhG+dS1+A@mail.gmail.com \
--to=or.gerlitz@gmail.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=eli@dev.mellanox.co.il \
--cc=eugenia@mellanox.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).