From: Or Gerlitz <or.gerlitz@gmail.com>
To: Tom Herbert <therbert@google.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 5/5] udp: additional GRO support
Date: Sun, 22 Jun 2014 14:40:31 +0300 [thread overview]
Message-ID: <CAJZOPZKQNK6uMB_ObYeBkJ1h3ybOpPmsurKCEHCForTR3Sv6kg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1406201631360.11831@tomh.mtv.corp.google.com>
On Sat, Jun 21, 2014 at 2:38 AM, Tom Herbert <therbert@google.com> wrote:
> Implement GRO for UDPv6. Add UDP checksum verification in gro_receive
> for both UDP4 and UDP6 calling skb_gro_checksum_validate_zero_check.
> Also, remove check for CHECKSUM_COMPLETE in udp_gro_receive, any
> checksum type should be handled now.
[...]
> diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c
> index fb8e6ba..2ab9051 100644
> --- a/net/ipv4/udp_offload.c
> +++ b/net/ipv4/udp_offload.c
> -static struct sk_buff **udp_gro_receive(struct sk_buff **head, struct sk_buff *skb)
> +struct sk_buff **udp_gro_receive(struct sk_buff **head, struct sk_buff *skb,
> + struct udphdr *uh)
> {
> struct udp_offload_priv *uo_priv;
> struct sk_buff *p, **pp = NULL;
> - struct udphdr *uh, *uh2;
> - unsigned int hlen, off;
> + struct udphdr *uh2;
> + unsigned int off = skb_gro_offset(skb);
> int flush = 1;
>
> - if (NAPI_GRO_CB(skb)->udp_mark ||
> - (!skb->encapsulation && skb->ip_summed != CHECKSUM_COMPLETE))
> + if (NAPI_GRO_CB(skb)->udp_mark)
> goto out;
Before this change we were practically requiring SKBs to carry their
->encapsulation mark set but not any more.
next prev parent reply other threads:[~2014-06-22 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 23:38 [PATCH 5/5] udp: additional GRO support Tom Herbert
2014-06-22 11:40 ` Or Gerlitz [this message]
2014-06-23 16:37 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZOPZKQNK6uMB_ObYeBkJ1h3ybOpPmsurKCEHCForTR3Sv6kg@mail.gmail.com \
--to=or.gerlitz@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).