From: Or Gerlitz <or.gerlitz@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: klebers@linux.vnet.ibm.com, ogerlitz@mellanox.com,
netdev@vger.kernel.org, jackm@dev.mellanox.co.il,
yevgenyp@mellanox.co.il, cascardo@linux.vnet.ibm.com,
brking@linux.vnet.ibm.com, shlomop@mellanox.com
Subject: Re: [PATCH] mlx4: Add support for EEH error recovery
Date: Tue, 24 Jul 2012 00:42:08 +0300 [thread overview]
Message-ID: <CAJZOPZKp4su8sOV1Cpm5CG2DYY2xVKUjrSFge5qcYn2pnkC-YA@mail.gmail.com> (raw)
In-Reply-To: <20120723.143436.2124127996154789223.davem@davemloft.net>
On Tue, Jul 24, 2012 at 12:34 AM, David Miller <davem@davemloft.net> wrote:
> Can we please move forward, if he implemented the feature properly
> and he tested it successfully, unless you can find a logic or
> stylistic flaw in his patch please ACK it.
>
> You can't hold his changes back while you work out how _YOU_ can
> test it to your liking.
Hi Dave,
We're trying to act in R/R (Responsive and Responsible) manner -
namely Shlomo did code review of the patches and we want to further
evaluate them by testing, I think its fully legitimate to test a patch
before ACK-ing. Doing these types of tests isn't around my personal
typical daily menu and I'm asking for some directives from the author
on how to issue that testing, I don't see what wrong here. We're
planning anyway to go deeper around this area and enhance the PCI
hotplug /error handling related code in the driver, so there's an
initial learing curve here, makes sense? we can move the Q&A for the
testing to be off-list if you prefer it to go that way.
Or.
next prev parent reply other threads:[~2012-07-23 21:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 19:55 [PATCH] mlx4: Add support for EEH error recovery Kleber Sacilotto de Souza
2012-07-22 10:29 ` Or Gerlitz
[not found] ` <500BD558.2060803@mellanox.com>
2012-07-23 0:15 ` David Miller
2012-07-23 13:18 ` Kleber Sacilotto de Souza
2012-07-23 13:45 ` Or Gerlitz
2012-07-23 18:12 ` Kleber Sacilotto de Souza
2012-07-23 20:53 ` Kleber Sacilotto de Souza
2012-07-23 21:26 ` Or Gerlitz
2012-07-23 21:34 ` David Miller
2012-07-23 21:42 ` Or Gerlitz [this message]
2012-07-23 21:44 ` David Miller
2012-07-23 22:02 ` Or Gerlitz
2012-07-23 22:21 ` David Miller
2012-07-24 13:12 ` Kleber Sacilotto de Souza
2012-07-24 17:09 ` Shlomo Pongartz
2012-07-24 17:35 ` Kleber Sacilotto de Souza
2012-07-24 18:08 ` Thadeu Lima de Souza Cascardo
2012-07-24 18:35 ` Shlomo Pongratz
2012-07-24 18:39 ` Shlomo Pongratz
2012-07-24 21:03 ` David Miller
2012-07-24 22:30 ` Or Gerlitz
2012-07-25 14:38 ` Shlomo Pongartz
[not found] ` <5010070B.5040405@mellanox.com>
2012-07-25 15:02 ` Kleber Sacilotto de Souza
2012-07-25 22:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZOPZKp4su8sOV1Cpm5CG2DYY2xVKUjrSFge5qcYn2pnkC-YA@mail.gmail.com \
--to=or.gerlitz@gmail.com \
--cc=brking@linux.vnet.ibm.com \
--cc=cascardo@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=jackm@dev.mellanox.co.il \
--cc=klebers@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=shlomop@mellanox.com \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).