From: Or Gerlitz <or.gerlitz@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: roland@kernel.org, netdev@vger.kernel.org, oren@mellanox.com,
yevgenyp@mellanox.com, amirv@mellanox.com
Subject: Re: [PATCH net-next 0/4] net/mlx4_en: Add accelerated RFS support
Date: Thu, 19 Jul 2012 00:22:42 +0300 [thread overview]
Message-ID: <CAJZOPZL8842H9H7404qjugCPpdhijjUhxk0Kn6BfBONCbE-tNA@mail.gmail.com> (raw)
In-Reply-To: <20120718.114158.2161516212050365274.davem@davemloft.net>
On Wed, Jul 18, 2012 at 9:41 PM, David Miller <davem@davemloft.net> wrote:
> Please use CONFIG_RFS_ACCEL consistently to protect this feature
> in your driver sources.
>
> Using CPU_RMAP in a few places is inconsistent, and not what other
> drivers do.
We're indeed using CONFIG_RFS_ACCEL across the place, and only in two
places which deal directly with rmap use CPU_RMAP. The latter is
selected by RFS_ACCEL, but if you feel this is inconsistent, will
change to use only one define.
Or.
next prev parent reply other threads:[~2012-07-18 21:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 14:19 [PATCH net-next 0/4] net/mlx4_en: Add accelerated RFS support Or Gerlitz
2012-07-18 14:19 ` [PATCH net-next 1/4] net/mlx4: Move MAC_MASK to a common place Or Gerlitz
2012-07-18 14:19 ` [PATCH net-next 2/4] net/rps: Protect cpu_rmap.h from double inclusion Or Gerlitz
2012-07-18 14:19 ` [PATCH net-next 3/4] {NET,IB}/mlx4: Add rmap support to mlx4_assign_eq Or Gerlitz
2012-07-18 14:19 ` [PATCH net-next 4/4] net/mlx4_en: Add accelerated RFS support Or Gerlitz
2012-07-18 18:41 ` [PATCH net-next 0/4] " David Miller
2012-07-18 21:22 ` Or Gerlitz [this message]
2012-07-18 21:34 ` David Miller
2012-07-18 21:36 ` Or Gerlitz
2012-07-18 21:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZOPZL8842H9H7404qjugCPpdhijjUhxk0Kn6BfBONCbE-tNA@mail.gmail.com \
--to=or.gerlitz@gmail.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oren@mellanox.com \
--cc=roland@kernel.org \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).