From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59B3C335A7 for ; Wed, 19 Jun 2024 15:34:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718811270; cv=none; b=qG77yfYJga+N49J8HgDLKaN8TT01tRmIQX+xknZfriBGyh2MLEjkIlnCVn3mIM8E7evbFIAVNsMHSCMm6CIAM//C5Pu4qjnc7yGZvbpRPVUDKd31PHQ+h6SCtgV9+vKL7AjfhAZmKvKt7NBSgE8jAhFt9ySalnulo1SfhAX6r7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718811270; c=relaxed/simple; bh=SyZw5x3PrOSKjnuwYIruwizBz8S5XAWHURMQrf+hBZw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=DRRtMtnjLFzLkigRYgjA1ZPUm991OTpjHvFN7mXHB3bp1bDSjPCN2U2Pt9zYuyZlNbyvXMNBbTRE3R/U2hSHOfiW2ISC+m9pPkBF5/b/M35P0jzeVZQsF7YAMKkGtYYTLEFSf4tvkAuJlaeerMbKm1gpBKkqppN/5PbCQbD5Cbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Kzi6K1O9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Kzi6K1O9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718811268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Z6cd0gXeCDMqMe2Sn9JeYqUvzxkN6ZqxSbh48wbjqY=; b=Kzi6K1O9yXJb1m6XtlaMYhs/zM5WPpGhHbbpndbNeLT/lWBuEMB0P1RbJuaBEcLwRZDdHS Ax4RKE6fWSFSGxxUNKdHNsgKIlUhQAuy5vdImge7e/2DP6kwu6KkZiW/ppUX7yeVpDcrnP vYSVEdlj5ff51h7q+1NKpxg+RIcKBYY= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-327-KejWPFa0MZ6H_ZTUdHaabw-1; Wed, 19 Jun 2024 11:34:27 -0400 X-MC-Unique: KejWPFa0MZ6H_ZTUdHaabw-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-627f43bec13so128389417b3.0 for ; Wed, 19 Jun 2024 08:34:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718811266; x=1719416066; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Z6cd0gXeCDMqMe2Sn9JeYqUvzxkN6ZqxSbh48wbjqY=; b=UeUGw5JVDsKPIcCwR8eKn8m8DhLpQqADhu0+RSIkg0BEYWu/h6Pcdiy2c9phqkTMH3 d8S1N1m6wFHz/c91WXSBbou1+ppRkQ3FsRHsaedDXwcftqrK19yXc3liKyjHRu1f204X vrC2+4sXP1do40ebFYo0/Xk1mTUDb5Zm9oewkABfXDzGN39Bcz5aM0kRxt6rHK+O7wX7 WPn/iUzRSCcs5Y1DB4o5idr2Gnt+IXh584Sya83Lxaqz9yhB3OMIqFsEEfHqnFXEWAUh OI8ZxXr7woplKbSmJsbvxOBkuGahRBAQTrHE03kNtUtwjEWDs7PlIz/dcDoIxZQQ2j8x M9cw== X-Forwarded-Encrypted: i=1; AJvYcCVyoy65uI6EvPNl76SgFeaelVxJKNPnpdZKV3rPEQwhOUEYeLBfJWVKveBP+ZsULRLP/Med8oCX7pUi8jyc9QcvOGdTBksj X-Gm-Message-State: AOJu0YxvDZhTNDH5XVay1hmECJlzs+tuVkzLjk0kLq/lFMzMti2rTgQ8 JCXur23Y2rfwK8B3Zt10l8Pzqo0nAArXSqkvXlytdMrjV41qOi3+uInwt3fAQDBJuEERq/Po5qp y5vxzxaILzx7LzJ6SPDsfrXJCuw+VAHOcs52g8ZTvOoGPJ80wyYgVkpJIlPyx+qWz0q4u9mV1vp 6cot3KgHmb409dopZTZRFLmLnbO4bk X-Received: by 2002:a25:6ac5:0:b0:dfe:148f:114f with SMTP id 3f1490d57ef6-e02be16c2acmr2786995276.27.1718811266512; Wed, 19 Jun 2024 08:34:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUWTR+p1MQws1i/MEYEjVgKq/tSc0AqXDfYlDvxq3BQdTNeJcL/NDUPxxwDuKICtSuQJkzJRGB/bJCvMMgtB0= X-Received: by 2002:a25:6ac5:0:b0:dfe:148f:114f with SMTP id 3f1490d57ef6-e02be16c2acmr2786967276.27.1718811266146; Wed, 19 Jun 2024 08:34:26 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240617-stage-vdpa-vq-precreate-v1-0-8c0483f0ca2a@nvidia.com> <20240617-stage-vdpa-vq-precreate-v1-13-8c0483f0ca2a@nvidia.com> In-Reply-To: <20240617-stage-vdpa-vq-precreate-v1-13-8c0483f0ca2a@nvidia.com> From: Eugenio Perez Martin Date: Wed, 19 Jun 2024 17:33:50 +0200 Message-ID: Subject: Re: [PATCH vhost 13/23] vdpa/mlx5: Set mkey modified flags on all VQs To: Dragos Tatulea Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Si-Wei Liu , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Cosmin Ratiu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jun 17, 2024 at 5:09=E2=80=AFPM Dragos Tatulea wrote: > > Otherwise, when virtqueues are moved from INIT to READY the latest mkey > will not be set appropriately. > > Signed-off-by: Dragos Tatulea > Reviewed-by: Cosmin Ratiu Acked-by: Eugenio P=C3=A9rez > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/ml= x5_vnet.c > index 0201c6fe61e1..0abe01fd20e9 100644 > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > @@ -2868,7 +2868,7 @@ static int mlx5_vdpa_change_map(struct mlx5_vdpa_de= v *mvdev, > > mlx5_vdpa_update_mr(mvdev, new_mr, asid); > > - for (int i =3D 0; i < ndev->cur_num_vqs; i++) > + for (int i =3D 0; i < mvdev->max_vqs; i++) > ndev->vqs[i].modified_fields |=3D MLX5_VIRTQ_MODIFY_MASK_= VIRTIO_Q_MKEY | > MLX5_VIRTQ_MODIFY_MASK_DE= SC_GROUP_MKEY; > > > -- > 2.45.1 >