From: Xie He <xie.he.0141@gmail.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Krzysztof Halasa <khc@pm.waw.pl>
Subject: Re: [PATCH net-next v4 5/5] net: hdlc_fr: Add support for any Ethertype
Date: Fri, 30 Oct 2020 12:29:46 -0700 [thread overview]
Message-ID: <CAJht_EMgWwAdo5Z3ZMs50k5tYnFetLa=zKO6unoU2mdOuXkU5g@mail.gmail.com> (raw)
In-Reply-To: <CA+FuTSdS86GtG15y17G0nNaqHjHTeYzFn+0N5+nTjXM8u=hpJw@mail.gmail.com>
On Fri, Oct 30, 2020 at 9:33 AM Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
>
> Should this still check data[5] == FR_PAD?
No, the 6th byte (data[5]) is not a padding field. It is the first
byte of the SNAP header. The original code is misleading. That is part
of the reasons why I want to fix it with this patch.
The frame format is specified in RFC 2427
(https://tools.ietf.org/html/rfc2427). We can see in Section 4.1 and
4.2 that the 6th byte is the first byte of the SNAP header.
next prev parent reply other threads:[~2020-10-30 19:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 2:28 [PATCH net-next v4 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype Xie He
2020-10-30 2:28 ` [PATCH net-next v4 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames Xie He
2020-10-30 16:34 ` Willem de Bruijn
2020-10-30 20:01 ` Xie He
2020-10-30 21:11 ` Willem de Bruijn
2020-10-30 21:27 ` Xie He
2020-10-30 2:28 ` [PATCH net-next v4 2/5] net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleaner Xie He
2020-10-30 2:28 ` [PATCH net-next v4 3/5] net: hdlc_fr: Improve the initial checks when we receive an skb Xie He
2020-10-30 16:30 ` Willem de Bruijn
2020-10-30 19:21 ` Xie He
2020-10-30 21:20 ` Willem de Bruijn
2020-10-30 21:36 ` Xie He
2020-10-30 2:28 ` [PATCH net-next v4 4/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices Xie He
2020-10-30 16:29 ` Willem de Bruijn
2020-10-30 20:08 ` Xie He
2020-10-30 21:28 ` Willem de Bruijn
2020-10-30 21:49 ` Xie He
2020-10-30 22:22 ` Willem de Bruijn
2020-10-30 22:52 ` Xie He
2020-10-30 2:28 ` [PATCH net-next v4 5/5] net: hdlc_fr: Add support for any Ethertype Xie He
2020-10-30 16:32 ` Willem de Bruijn
2020-10-30 19:29 ` Xie He [this message]
2020-10-30 21:25 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJht_EMgWwAdo5Z3ZMs50k5tYnFetLa=zKO6unoU2mdOuXkU5g@mail.gmail.com' \
--to=xie.he.0141@gmail.com \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).