From: Xie He <xie.he.0141@gmail.com>
To: Martin Schiller <ms@dev.tdt.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux X25 <linux-x25@vger.kernel.org>
Subject: Re: [PATCH v2] drivers/net/wan/x25_asy: Fix to make it work
Date: Mon, 20 Jul 2020 10:58:03 -0700 [thread overview]
Message-ID: <CAJht_EOZZFE0-Os90-CyO9M8xX-B7UYWaTHcLiFOcGvHh3TB7A@mail.gmail.com> (raw)
In-Reply-To: <b2836ae012e0c57ba01ba1dee0a9eacd@dev.tdt.de>
On Mon, Jul 20, 2020 at 4:23 AM -0700
Martin Schiller <ms@dev.tdt.de> wrote:
>
> LGTM.
>
> I have never used the driver, but the adjustments look conclusive. The
> functionality is now comparable to the one in the drivers lapbether or
> hdlc_x25.
>
> Reviewed-by: Martin Schiller <ms@dev.tdt.de>
>
Thank you so much!
next prev parent reply other threads:[~2020-07-20 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 23:44 [PATCH v2] drivers/net/wan/x25_asy: Fix to make it work Xie He
2020-07-20 11:23 ` Martin Schiller
2020-07-20 17:58 ` Xie He [this message]
2020-07-22 1:30 ` David Miller
2020-07-22 3:10 ` Xie He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJht_EOZZFE0-Os90-CyO9M8xX-B7UYWaTHcLiFOcGvHh3TB7A@mail.gmail.com \
--to=xie.he.0141@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).