From: Roopa Prabhu <roopa@cumulusnetworks.com>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 5/5] ipv6: route: dissect flow in input path if fib rules need it
Date: Sun, 25 Feb 2018 19:40:34 -0800 [thread overview]
Message-ID: <CAJieiUgZpBFs5RJD=AAssLqSxJsFuEMHXCAsQyO=dxe4OpSVGQ@mail.gmail.com> (raw)
In-Reply-To: <9f3f444a-01ac-ebb3-b342-c6ba05c6f3bc@cumulusnetworks.com>
On Sun, Feb 25, 2018 at 7:19 PM, David Ahern <dsa@cumulusnetworks.com> wrote:
> On 2/24/18 10:44 PM, Roopa Prabhu wrote:
>
>> @@ -1847,12 +1858,27 @@ void ip6_route_input(struct sk_buff *skb)
>> .flowi6_mark = skb->mark,
>> .flowi6_proto = iph->nexthdr,
>> };
>> + struct flow_keys *flkeys = NULL, _flkeys;
>>
>> tun_info = skb_tunnel_info(skb);
>> if (tun_info && !(tun_info->mode & IP_TUNNEL_INFO_TX))
>> fl6.flowi6_tun_key.tun_id = tun_info->key.tun_id;
>> +
>> +#ifdef CONFIG_IPV6_MULTIPLE_TABLES
>> + if (net->ipv6.fib6_rules_require_fldissect) {
>> + unsigned int flag = FLOW_DISSECTOR_F_STOP_AT_ENCAP;
>> +
>> + memset(&_flkeys, 0, sizeof(_flkeys));
>> + skb_flow_dissect_flow_keys(skb, &_flkeys, flag);
>> + fl6.fl6_sport = _flkeys.ports.src;
>> + fl6.fl6_dport = _flkeys.ports.dst;
>> + fl6.flowi6_proto = _flkeys.basic.ip_proto;
>> + flkeys = &_flkeys;
>> + }
>> +#endif
>
> same here - helper versus inline.
>
ack
next prev parent reply other threads:[~2018-02-26 3:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 5:44 [PATCH net-next 0/5] fib_rules: support sport, dport and ip proto match Roopa Prabhu
2018-02-25 5:44 ` [PATCH net-next 1/5] net: fib_rules: support for match on ip_proto, sport and dport Roopa Prabhu
2018-02-25 15:04 ` Nikolay Aleksandrov
2018-02-25 15:27 ` Nikolay Aleksandrov
2018-02-25 17:58 ` Roopa Prabhu
2018-02-26 3:08 ` David Ahern
2018-02-26 3:38 ` Roopa Prabhu
2018-02-25 5:44 ` [PATCH net-next 2/5] ipv4: fib_rules: support match on sport, dport and ip proto Roopa Prabhu
2018-02-25 5:44 ` [PATCH net-next 3/5] ipv6: fib6_rules: support for " Roopa Prabhu
2018-02-25 5:44 ` [PATCH net-next 4/5] ipv4: route: dissect flow in input path if fib rules need it Roopa Prabhu
2018-02-25 15:08 ` Nikolay Aleksandrov
2018-02-26 3:17 ` David Ahern
2018-02-26 9:10 ` Paolo Abeni
2018-02-26 15:36 ` Roopa Prabhu
2018-02-25 5:44 ` [PATCH net-next 5/5] ipv6: " Roopa Prabhu
2018-02-25 15:10 ` Nikolay Aleksandrov
2018-02-25 17:51 ` Roopa Prabhu
2018-02-26 3:19 ` David Ahern
2018-02-26 3:40 ` Roopa Prabhu [this message]
2018-02-26 3:20 ` [PATCH net-next 0/5] fib_rules: support sport, dport and ip proto match David Ahern
2018-02-26 3:39 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJieiUgZpBFs5RJD=AAssLqSxJsFuEMHXCAsQyO=dxe4OpSVGQ@mail.gmail.com' \
--to=roopa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).