netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Thompson <ptf@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [PATCH] r8169: Disable multicast filter for RTL_GIGA_MAC_VER_46
Date: Fri, 1 Sep 2023 08:28:39 -0400	[thread overview]
Message-ID: <CAJs+hrEO6nqRHPj4kUWRm3UsBiSOU128a4pLEp8p4pokP7MmEg@mail.gmail.com> (raw)
In-Reply-To: <20230606142907.456eec7e@kernel.org>

Hello,

I was wondering if this should be extended to all RTL_GIGA_MAC_VERs
greater than 35 as well.

Realtek responded to me but I was slow to get them packet captures
that they needed. I am hoping to restart things and get back to this
over the finish line if it's a valid patch.

I will add the appropriate tags and annotations once I hear back.

On Tue, Jun 6, 2023 at 5:29 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 6 Jun 2023 17:11:27 +0200 Heiner Kallweit wrote:
> > Thanks for the report and the patch. I just asked a contact in Realtek
> > whether more chip versions may be affected. Then the patch should be
> > extended accordingly. Let's wait few days for a response.
> >
> > I think we should make this a fix. Add the following as Fixes tag
> > and annotate the patch as "net" (see netdev FAQ).
> >
> > 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
>
> Perhaps it's best if you repost with the Fixes tag included once
> Realtek responded.

  reply	other threads:[~2023-09-01 12:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 14:00 [PATCH] r8169: Disable multicast filter for RTL_GIGA_MAC_VER_46 Patrick Thompson
2023-06-06 14:15 ` Patrick Thompson
2023-06-06 15:11   ` Heiner Kallweit
2023-06-06 21:29     ` Jakub Kicinski
2023-09-01 12:28       ` Patrick Thompson [this message]
2023-09-01 12:48         ` Heiner Kallweit
2023-09-01 14:20           ` Patrick Thompson
2023-09-01 15:44             ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJs+hrEO6nqRHPj4kUWRm3UsBiSOU128a4pLEp8p4pokP7MmEg@mail.gmail.com \
    --to=ptf@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).