From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xue Liu Subject: Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig Date: Tue, 18 Dec 2018 14:50:58 +0100 Message-ID: References: <20181216101858.9585-7-starnight@g.ncu.edu.tw> <8bfdccbf-fb47-daa5-fbd0-ed16a3d6d334@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: Jian-Hong Pan , "David S . Miller" , Alan Cox , linux-lpwan@lists.infradead.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marcel Holtmann , Dollar Chen , Ken Yu , linux-wpan - ML To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Return-path: In-Reply-To: <8bfdccbf-fb47-daa5-fbd0-ed16a3d6d334@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello Andreas, On Mon, 17 Dec 2018 at 15:19, Andreas F=C3=A4rber wrote: > > Hello Xue Liu, > > Am 17.12.18 um 09:50 schrieb Xue Liu: > > I have a question about the architecture of your module. AFAIK LoRaWAN > > is already the MAC Layer above the LoRa technology. Why do you want to > > make a new layer called "maclorawan" ? > > I had asked Jian-Hong to separate between his soft-MAC implementation > and the common bits needed to drive hard-MAC implementations found on > several of the hardware modules made available to me. > As a reference Linux 802.11 uses cfg80211 to talk with hard-MAC devices. We may also use the name =E2=80=9Ccfglora=E2=80=9D for hard-MAC implementat= ion. > The prefix "mac" was copied from mac80211 and mac802154: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/n= et > OK. Understood. I guess they use mac80211 and mac802154 to distinguish physical layer and MAC layer. Since LoRa and LoRaWAN are already separate I think "maclorawan" is not necessary. > If you have better ideas for how to structure this, just let us know, > ideally as inline comment where you see it (or on the cover letter). > > Only comment I have for this patch at the moment is that I would prefer > to have the Kconfig bits be in the patches adding the code, so that we > can actually build-test them before 6/6. > > Been updating my lab to 4.20-rcX with some hiccups. Ben's > regmap_noinc_write support made it into 4.20, so I expect to have Ben's > pending branch for sx1301 merged into rebased lora-next before Christmas > and my sx1276 conversion to follow, leaving the PF_PACKET vs. PF_LORA > discussion from ELCE - haven't assessed yet how much this series would > be affected by the underlying changes, but if the abstraction was done > right then only maclorawan implementation should be affected. > > Regards, > Andreas > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton > HRB 21284 (AG N=C3=BCrnberg) Regards, Xue Liu --