From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84638C0502C for ; Thu, 1 Sep 2022 12:50:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232682AbiIAMug (ORCPT ); Thu, 1 Sep 2022 08:50:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232804AbiIAMuc (ORCPT ); Thu, 1 Sep 2022 08:50:32 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98AA414086 for ; Thu, 1 Sep 2022 05:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662036628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WVR8ZGAEIG6jlDjc/QlrwfVcZSi0Y+I1JEJbD87FRlM=; b=GWzmbg+WO85QlVaDNczXXRg+bY2F0HHRKt98YYJetLOIYI1hdpvv3BhIzrEyhGK/Nd8MKj RWJ7+1anh0BePk80bJth3fUdZcK9q6b+sg0asbHlOO7vFozAuTv6eBhRulcEzOIi6ne38x h4EZMgLtICxoxzccBQHZe76O3pflxzg= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-630-v_Yd9yg4NEayIZAC0jSfgw-1; Thu, 01 Sep 2022 08:50:27 -0400 X-MC-Unique: v_Yd9yg4NEayIZAC0jSfgw-1 Received: by mail-qt1-f199.google.com with SMTP id k9-20020ac80749000000b0034302b53c6cso13635963qth.22 for ; Thu, 01 Sep 2022 05:50:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=WVR8ZGAEIG6jlDjc/QlrwfVcZSi0Y+I1JEJbD87FRlM=; b=y6Az2WnBu6WOI5NwuvKNvjO8BBy4xyrbREU2EvckZ5I9PtcvB4bxAoe4PBAP91qJBM hfgUcgTpuDX1dHseAjVGu10h/RkRlFjzn53HsbpNGhNtKe/g5ItQbJTAEnwzLYwdf+Rq G8UrAEBpdP4SxmB9+Kgv206rQMh/ZJyNG0OOEW9876AItC8uQ7KHY7WgjRNqYnGbB3N4 coMMbZLelrDQC2uIh5jFpdimsIZoeRYoXdVwi7rfRqSLHt9CNz7oWQ8Hl3Ef24VxM5jT 9fg9B9gNDOWPaJzVJ/n/AO4gosyxIydytCETQuwovwsY5M6jlzZiwMC48/PeksJq3UXY uvpg== X-Gm-Message-State: ACgBeo1E8iXUFmidWMmxtqGLRT58e/C2ENE7o343U+fUGub52PRhq2cU MZJbdIwogv0H+v4H9Snm05A4uvvAqXy+T1CcSMA+h991oJTfqmOdEoNCO8tkdG/GLIDBCPUEt4R Ug7VFe1LA6LxhB6we1hbATs67+ayPoVVC X-Received: by 2002:a05:622a:1302:b0:344:8a9d:817d with SMTP id v2-20020a05622a130200b003448a9d817dmr23373426qtk.339.1662036627276; Thu, 01 Sep 2022 05:50:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR6kObCOgs/8rlva+gwEleVWuBVvZa2Nyj96/+b0fIJuQ008mmaRhNAh00YlyzT5ptnDqJFoMc9wUD036tD5Faw= X-Received: by 2002:a05:622a:1302:b0:344:8a9d:817d with SMTP id v2-20020a05622a130200b003448a9d817dmr23373413qtk.339.1662036627064; Thu, 01 Sep 2022 05:50:27 -0700 (PDT) MIME-Version: 1.0 References: <20220830101237.22782-1-gal@nvidia.com> <20220830231330.1c618258@kernel.org> <4187e35d-0965-cf65-bff5-e4f71a04d272@nvidia.com> <20220830233124.2770ffc2@kernel.org> <20220831112150.36e503bd@kernel.org> <36f09967-b211-ef48-7360-b6dedfda73e3@datenfreihafen.org> <20220831140947.7e8d06ee@kernel.org> In-Reply-To: From: Alexander Aring Date: Thu, 1 Sep 2022 08:50:16 -0400 Message-ID: Subject: Re: [PATCH net-next] net: ieee802154: Fix compilation error when CONFIG_IEEE802154_NL802154_EXPERIMENTAL is disabled To: Leon Romanovsky Cc: Jakub Kicinski , Stefan Schmidt , Alexander Aring , Gal Pressman , "David S. Miller" , Network Development , linux-wpan - ML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On Thu, Sep 1, 2022 at 2:38 AM Leon Romanovsky wrote: > > On Wed, Aug 31, 2022 at 02:09:47PM -0700, Jakub Kicinski wrote: > > On Wed, 31 Aug 2022 22:59:14 +0200 Stefan Schmidt wrote: > > > I was swamped today and I am only now finding time to go through mail. > > > > > > Given the problem these ifdef are raising I am ok with having these > > > commands exposed without them. > > > > > > Our main reason for having this feature marked as experimental is that > > > it does not have much exposure and we fear that some of it needs rewrites. > > > > > > If that really is going to happen we will simply treat the current > > > commands as reserved/burned and come up with other ones if needed. While > > > I hope this will not be needed it is a fair plan for mitigating this. > > > > Thanks for the replies. I keep going back and forth in my head on > > what's better - un-hiding or just using NL802154_CMD_SET_WPAN_PHY_NETNS + 1 > > as the start of validation, since it's okay to break experimental commands. > > > > Any preference? > > Jakub, > > There is no such thing like experimental UAPI. Once you put something > in UAPI headers and/or allowed users to issue calls from userspace > to kernel, they can use it. We don't control how users compile their > kernels. > > So it is not break "experimental commands", but break commands that > maybe shouldn't exist in first place. > > nl802154 code suffers from two basic mistakes: > 1. User visible defines are not part of UAPI headers. For example, > include/net/nl802154.h should be in include/uapi/net/.... yes, but no because then this will end in breaking UAPI because it will be exported to uapi headers if we change them? For now we say everybody needs to copy the header on their own into their user space application if they want to use the API which means it fits for the kernel that they copied from. > 2. Used Kconfig option for pseudo-UAPI header. > > In this specific case, I checked that Fedora didn't enable this > CONFIG_IEEE802154_NL802154_EXPERIMENTAL knob, but someone needs > to check debian and other distros too. > I would remove the CONFIG_IEEE802154_NL802154_EXPERIMENTAL config option but don't move the header to "include/uapi/..." which means that the whole nl802154 UAPI (and some others UAPIs) are still experimental because it's not part of UAPI "directory". btw: the whole subsystem is still experimental because f4671a90c418 ("net/ieee802154: remove depends on CONFIG_EXPERIMENTAL") was never acked by any maintainer... but indeed has other reasons why it got removed. - Alex