Re: [PATCH net-next 2/2] tcp: new TCP_INFO stats for RTO events

[Yuchung Cheng <ycheng@google.com>]

On Thu, Sep 14, 2023 at 5:02 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> Hi,
>
> On Tue, 2023-09-12 at 02:33 +0000, Aananth V wrote:
> > @@ -2825,6 +2829,14 @@ void tcp_enter_recovery(struct sock *sk, bool ece_ack)
> >       tcp_set_ca_state(sk, TCP_CA_Recovery);
> >  }
> >
> > +static inline void tcp_update_rto_time(struct tcp_sock *tp)
> > +{
> > +     if (tp->rto_stamp) {
> > +             tp->total_rto_time += tcp_time_stamp(tp) - tp->rto_stamp;
> > +             tp->rto_stamp = 0;
> > +     }
> > +}
>
> The CI is complaining about 'inline' function in .c file. I guess that
> is not by accident and the goal is to maximize fast-path performances?
>
> Perhaps worthy moving the function to an header file to make static
> checkers happy?

or simply remove the inline keyword since it's only used in that file.
>
>
> Thanks!
>
> Paolo
>