From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] [RFC v3] packet: experimental support for 64-bit timestamps
Date: Wed, 29 Nov 2017 21:06:10 +0100
Message-ID: <CAK8P3a14x_1fFRdS0avr-abCem+TZas7jknH_o+93aNtvtiTAw@mail.gmail.com>
References: <CAK8P3a0DTCr3s+ShSLswY6rnGzCiK1i1Pf283fZEb-q-wcfZ_g@mail.gmail.com>
 <20171128203346.1582725-1-arnd@arndb.de> <CAF=yD-JXkYR9Fw+2pPjYUXf-6MgJO5AvVYCYJWNLWCM+bqfZFQ@mail.gmail.com>
 <CAK8P3a2w=JYfptNdKho5EdriRMHH60AA9MLTVHGf9QVf3jgDxg@mail.gmail.com> <CAF=yD-+UOPN+fJSHDp7ytiABM1aS1JD6Q-o-nvBc6d2Wzet6Qg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: "David S. Miller" <davem@davemloft.net>,
        Willem de Bruijn <willemb@google.com>,
        =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@gmail.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Mike Maloney <maloney@google.com>,
        Eric Dumazet <edumazet@google.com>,
        Kees Cook <keescook@chromium.org>,
        Hans Liljestrand <ishkamiel@gmail.com>,
        Andrey Konovalov <andreyknvl@google.com>,
        "Rosen, Rami" <rami.rosen@intel.com>,
        "Reshetova, Elena" <elena.reshetova@intel.com>,
        Sowmini Varadhan <sowmini.varadhan@oracle.com>,
        Network Development <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CAF=yD-+UOPN+fJSHDp7ytiABM1aS1JD6Q-o-nvBc6d2Wzet6Qg@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Wed, Nov 29, 2017 at 5:51 PM, Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
>> Thanks for the review! Any suggestions for how to do the testing? If you have
>> existing test cases, could you give my next version a test run to see if there
>> are any regressions and if the timestamps work as expected?
>>
>> I see that there are test cases in tools/testing/selftests/net/, but none
>> of them seem to use the time stamps so far, and I'm not overly familiar
>> with how it works in the details to extend it in a meaningful way.
>
> I could not find any good tests for this interface, either. The only
> user of the interface I found was a little tool I wrote a few years
> ago that compares timestamps at multiple points in the transmit
> path for latency measurement [1]. But it may be easier to just write
> a new test under tools/testing/selftests/net for this purpose. I can
> help with that, too, if you want.

Thanks, that would be great!

     Arnd