From: Arnd Bergmann <arnd@arndb.de>
To: Greentime Hu <green.hu@gmail.com>
Cc: sparclinux <sparclinux@vger.kernel.org>,
Greentime <greentime@andestech.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Networking <netdev@vger.kernel.org>,
Vincent Chen <deanbo422@gmail.com>,
DTML <devicetree@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Will Deacon <will.deacon@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-serial@vger.kernel.org,
Geert Uytterhoeven <geert.uytterhoeven@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Rutland <mark.rutland@arm.com>, Greg KH <greg@kroah.com>,
Guo Ren <ren_guo@c-sky.com>, Randy Dunlap <rdunlap@infradead.org>,
David Miller <davem@davemloft.net>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>
Subject: Re: [PATCH v7 03/37] sparc: io: To use the define of ioremap_[nocache|wc|wb] in asm-generic/io.h
Date: Wed, 21 Feb 2018 13:27:55 +0100 [thread overview]
Message-ID: <CAK8P3a19k92HhqEVBYO7wqx77k5PN6t_-9UbbU-DDYfZrnUUhA@mail.gmail.com> (raw)
In-Reply-To: <CAEbi=3eCfWYXZiN+5uaSqDKcEs1Kf3Av=ua6LCZmy2jAy5-Fdw@mail.gmail.com>
On Wed, Feb 21, 2018 at 9:05 AM, Greentime Hu <green.hu@gmail.com> wrote:
> 2018-02-14 22:43 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
>> On Tue, Feb 13, 2018 at 10:09 AM, Greentime Hu <green.hu@gmail.com> wrote:
>>> A commit for the nds32 architecture bootstrap("asm-generic/io.h: move
>>> ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU")
>>> will move the ioremap_nocache out of the CONFIG_MMU ifdef. This means that
>>> in order to suppress re-definition errors we need to remove the #define
>>> in io_32.h.
>>>
>>> Also, the change adds a prototype for ioremap where size is size_t and
>>> offset is phys_addr_t so fix that as well.
>>>
>>> Signed-off-by: Greentime Hu <greentime@andestech.com>
>>
>> This patch should have been addressed to the sparclinux mailing list to
>> the maintainers can see it, otherwise they are unlikely to notice.
>>
>> Added it to Cc now.
>>
>> Can you confirm that the patches are ordered correctly in your series so that
>> at no point, sparc is in a state that fails to be build cleanly?
>>
>> If not, this may have to get merged into the other patch.
>
> Hi, Arnd:
>
> These 2 patch will cause sparc building error in any order.
>
> Should I merge them together like this?
>
> asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of
> ifndef CONFIG_MMU
>
> It allows some architectures to use this generic macro instead of
> defining theirs.
>
> sparc: io: To use the define of ioremap_[nocache|wc|wb] in asm-generic/io.h
> It will move the ioremap_nocache out of the CONFIG_MMU ifdef. This means that
> in order to suppress re-definition errors we need to remove the #define
> in arch/sparc/include/asm/io_32.h. Also, the change adds a prototype for
> ioremap where size is size_t and offset is phys_addr_t so fix that as well.
>
> Signed-off-by: Greentime Hu <greentime@andestech.com>
That looks reasonable since both patches are fairly small, yes.
For a more complex patch that requires interdependent changes
in different areas of the kernel, it may be necessary instead to
come up with a way to stage out the changes differently so they
are truly independent. Getting that right requires a bit practice
but is usually possible.
Arnd
next prev parent reply other threads:[~2018-02-21 12:27 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 9:09 [PATCH v7 00/37] Andes(nds32) Linux Kernel Port Greentime Hu
2018-02-13 9:09 ` [PATCH v7 01/37] openrisc: add ioremap_nocache declaration before include asm-generic/io.h and sync ioremap prototype with it Greentime Hu
2018-02-13 9:09 ` [PATCH v7 02/37] asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU Greentime Hu
[not found] ` <ff404658ececd53f1bf111067c587c4e3eb695af.1518505384.git.greentime-MUIXKm3Oiri1Z/+hSey0Gg@public.gmane.org>
2018-02-16 9:30 ` kbuild test robot
2018-02-16 10:47 ` kbuild test robot
2018-02-21 11:21 ` Greentime Hu
2018-02-21 11:37 ` Arnd Bergmann
2018-02-21 12:02 ` Greentime Hu
2018-02-13 9:09 ` [PATCH v7 03/37] sparc: io: To use the define of ioremap_[nocache|wc|wb] in asm-generic/io.h Greentime Hu
2018-02-14 14:43 ` Arnd Bergmann
2018-02-21 8:05 ` Greentime Hu
2018-02-21 12:27 ` Arnd Bergmann [this message]
2018-02-13 9:09 ` [PATCH v7 05/37] drivers/video/concole: add negative dependency for VGA_CONSOLE on nds32 Greentime Hu
2018-02-13 9:09 ` [PATCH v7 06/37] nds32: Assembly macros and definitions Greentime Hu
2018-02-13 9:09 ` [PATCH v7 07/37] nds32: Kernel booting and initialization Greentime Hu
2018-02-14 14:35 ` Arnd Bergmann
2018-02-13 9:09 ` [PATCH v7 08/37] nds32: Exception handling Greentime Hu
2018-02-14 14:31 ` Arnd Bergmann
2018-02-13 9:09 ` [PATCH v7 09/37] nds32: MMU definitions Greentime Hu
2018-02-13 9:09 ` [PATCH v7 10/37] nds32: MMU initialization Greentime Hu
2018-02-13 9:09 ` [PATCH v7 11/37] nds32: MMU fault handling and page table management Greentime Hu
2018-02-13 9:09 ` [PATCH v7 12/37] nds32: Cache and TLB routines Greentime Hu
2018-02-13 9:09 ` [PATCH v7 13/37] nds32: Process management Greentime Hu
2018-02-13 9:09 ` [PATCH v7 14/37] nds32: IRQ handling Greentime Hu
2018-02-13 9:09 ` [PATCH v7 15/37] nds32: Atomic operations Greentime Hu
2018-02-13 9:09 ` [PATCH v7 16/37] nds32: Device specific operations Greentime Hu
2018-02-13 9:09 ` [PATCH v7 17/37] nds32: DMA mapping API Greentime Hu
2018-02-13 9:09 ` [PATCH v7 18/37] nds32: ELF definitions Greentime Hu
2018-02-13 9:09 ` [PATCH v7 19/37] nds32: System calls handling Greentime Hu
[not found] ` <cover.1518505384.git.greentime-MUIXKm3Oiri1Z/+hSey0Gg@public.gmane.org>
2018-02-13 9:09 ` [PATCH v7 04/37] earlycon: add reg-offset to physical address before mapping Greentime Hu
2018-02-15 15:40 ` Rob Herring
2018-02-28 12:39 ` Greg Kroah-Hartman
2018-02-13 9:09 ` [PATCH v7 20/37] nds32: VDSO support Greentime Hu
2018-02-13 9:09 ` [PATCH v7 21/37] nds32: Signal handling support Greentime Hu
2018-02-13 9:09 ` [PATCH v7 22/37] nds32: Library functions Greentime Hu
2018-02-13 9:09 ` [PATCH v7 23/37] nds32: Debugging support Greentime Hu
2018-02-14 14:32 ` Arnd Bergmann
2018-02-13 9:09 ` [PATCH v7 24/37] nds32: L2 cache support Greentime Hu
2018-02-13 9:09 ` [PATCH v7 25/37] nds32: Loadable modules Greentime Hu
2018-02-13 9:09 ` [PATCH v7 26/37] nds32: Generic timers support Greentime Hu
2018-02-13 9:09 ` [PATCH v7 27/37] nds32: Device tree support Greentime Hu
2018-02-13 9:09 ` [PATCH v7 28/37] nds32: Miscellaneous header files Greentime Hu
2018-02-13 9:09 ` [PATCH v7 29/37] nds32: defconfig Greentime Hu
2018-02-13 9:09 ` [PATCH v7 30/37] nds32: Build infrastructure Greentime Hu
2018-02-14 14:34 ` Arnd Bergmann
2018-02-13 9:09 ` [PATCH v7 31/37] MAINTAINERS: Add nds32 Greentime Hu
2018-02-13 16:02 ` Joe Perches
[not found] ` <1518537768.22190.42.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2018-02-14 5:54 ` Greentime Hu
2018-02-13 9:09 ` [PATCH v7 32/37] dt-bindings: nds32 CPU Bindings Greentime Hu
2018-02-13 9:09 ` [PATCH v7 33/37] dt-bindings: nds32 L2 cache controller Bindings Greentime Hu
2018-02-13 9:09 ` [PATCH v7 34/37] dt-bindings: nds32 SoC Bindings Greentime Hu
2018-02-13 9:09 ` [PATCH v7 35/37] dt-bindings: interrupt-controller: Andestech Internal Vector Interrupt Controller Greentime Hu
2018-02-13 9:09 ` [PATCH v7 36/37] irqchip: Andestech Internal Vector Interrupt Controller driver Greentime Hu
2018-02-13 9:09 ` [PATCH v7 37/37] net: faraday add nds32 support Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a19k92HhqEVBYO7wqx77k5PN6t_-9UbbU-DDYfZrnUUhA@mail.gmail.com \
--to=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=deanbo422@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=geert.uytterhoeven@gmail.com \
--cc=green.hu@gmail.com \
--cc=greentime@andestech.com \
--cc=greg@kroah.com \
--cc=jason@lakedaemon.net \
--cc=jonas@southpole.se \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=ren_guo@c-sky.com \
--cc=robh+dt@kernel.org \
--cc=shorne@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).