From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 40/47] netfilter: nf_tables: build-in filter chain type Date: Wed, 4 Apr 2018 17:38:31 +0200 Message-ID: References: <20180330114619.18797-1-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: netfilter-devel@vger.kernel.org, David Miller , Networking To: Pablo Neira Ayuso Return-path: Received: from mail-qt0-f196.google.com ([209.85.216.196]:33141 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125AbeDDPid (ORCPT ); Wed, 4 Apr 2018 11:38:33 -0400 In-Reply-To: <20180330114619.18797-1-pablo@netfilter.org> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Mar 30, 2018 at 1:46 PM, Pablo Neira Ayuso wrote: > One module per supported filter chain family type takes too much memory > for very little code - too much modularization - place all chain filter > definitions in one single file. > > Signed-off-by: Pablo Neira Ayuso Hi Pablo, I've bisected a link error to this patch: net/netfilter/nft_reject_inet.o: In function `nft_reject_inet_eval': nft_reject_inet.c:(.text+0xa7): undefined reference to `nf_send_unreach6' nft_reject_inet.c:(.text+0x10c): undefined reference to `nf_send_unreach6' nft_reject_inet.c:(.text+0x138): undefined reference to `nf_send_reset6' Unfortunately I don't immediately see what went wrong, maybe you can spot it. Arnd