From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling Date: Thu, 8 Nov 2018 22:02:25 +0100 Message-ID: References: <1541702161-30673-1-git-send-email-sunil.kovvuri@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Networking , David Miller , linux-soc@vger.kernel.org, Sunil Goutham To: Sunil Kovvuri Return-path: Received: from mail-qk1-f194.google.com ([209.85.222.194]:45338 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbeKIGj6 (ORCPT ); Fri, 9 Nov 2018 01:39:58 -0500 In-Reply-To: <1541702161-30673-1-git-send-email-sunil.kovvuri@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Nov 8, 2018 at 7:36 PM wrote: > > From: Sunil Goutham Hmm, I noticed that you use a different address as the patch author and the submitter. I'm guessing that "Sunil Goutham" and "Sunil Kovvuri" actually refer to the same person, and you just need to pick which of the two email addresses you want to use for public communication, but that's not obvious here. However, if there are actually two different Sunil's here, then you need to add that second Signed-off-by. I've taken a look at all the patches now, and found very little sticking out that warranted a comment from my side, and no real show-stoppers. That said, I found this series overall much harder to understand than the previous ones, and don't even know what to ask about it. My feeling is that it's probably all fine, but that is purely based on a review of the individual pieces, not the overall design and how they fit together. With the earlier patches that I managed to get a better understanding of, that seemed reasonable as well. Arnd