From: Edwin Peer <edwin.peer@broadcom.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Danielle Ratson <danieller@nvidia.com>,
Michal Kubecek <mkubecek@suse.cz>,
netdev <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jiri Pirko <jiri@nvidia.com>, Andrew Lunn <andrew@lunn.ch>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
mlxsw <mlxsw@nvidia.com>, Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next v3 2/7] ethtool: Get link mode in use instead of speed and duplex parameters
Date: Mon, 1 Feb 2021 13:05:10 -0800 [thread overview]
Message-ID: <CAKOOJTw75uLVPpzV1a85SFsO7Gz9bcfS9M1CWHQONCfMLC4H6g@mail.gmail.com> (raw)
In-Reply-To: <20210201122939.09c18efa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
On Mon, Feb 1, 2021 at 12:29 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > I think it should be deterministic. It should be possible to select
> > the appropriate mode either based on the current media type or the
> > current link mode (which implies a media type). Alternatively, if the
> > user space request only specifies a subset, such as speed, fall back
> > to the existing behaviour and don't supply the request to the driver
> > in the form of a compound link mode in those cases (perhaps indicating
> > this by not setting the capability bit). The former approach has the
> > potential to tidy up drivers if we decide that drivers providing the
> > capability can ignore the other fields and rely solely on link mode,
> > the latter is no worse than what we have today.
>
> The media part is beginning to sound concerning. Every time we
> under-specify an interface we end up with #vendors different
> interpretations. And since HW is programmed by FW in most high
> speed devices we can't even review the right thing is done.
Each link mode implies a very specific media type, the kernel can
reject illegal combinations based on the supported bitmask before
calling upon the driver to select it.
Regards,
Edwin Peer
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4160 bytes --]
next prev parent reply other threads:[~2021-02-01 21:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 9:37 [PATCH net-next v3 0/7] Support setting lanes via ethtool Danielle Ratson
2021-01-20 9:37 ` [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes Danielle Ratson
2021-01-20 22:35 ` Edwin Peer
2021-02-02 18:08 ` Danielle Ratson
2021-01-22 3:44 ` Jakub Kicinski
2021-01-25 15:53 ` Danielle Ratson
2021-01-25 19:02 ` Jakub Kicinski
2021-01-20 9:37 ` [PATCH net-next v3 2/7] ethtool: Get link mode in use instead of speed and duplex parameters Danielle Ratson
2021-01-20 23:39 ` Edwin Peer
2021-01-24 8:36 ` Danielle Ratson
2021-01-25 18:03 ` Edwin Peer
2021-01-26 17:06 ` Danielle Ratson
2021-01-26 17:14 ` Edwin Peer
2021-01-27 13:22 ` Danielle Ratson
2021-01-28 20:26 ` Michal Kubecek
2021-01-31 15:33 ` Danielle Ratson
2021-01-31 17:39 ` Edwin Peer
2021-02-01 13:49 ` Danielle Ratson
2021-02-01 18:14 ` Edwin Peer
2021-02-01 20:29 ` Jakub Kicinski
2021-02-01 21:05 ` Edwin Peer [this message]
2021-02-01 21:41 ` Jakub Kicinski
2021-02-01 21:59 ` Edwin Peer
2021-02-01 22:20 ` Jakub Kicinski
2021-02-02 0:14 ` Edwin Peer
2021-02-02 1:08 ` Jakub Kicinski
2021-01-20 9:37 ` [PATCH net-next v3 3/7] ethtool: Expose the number of lanes in use Danielle Ratson
2021-01-20 9:37 ` [PATCH net-next v3 4/7] mlxsw: ethtool: Remove max lanes filtering Danielle Ratson
2021-01-20 9:37 ` [PATCH net-next v3 5/7] mlxsw: ethtool: Add support for setting lanes when autoneg is off Danielle Ratson
2021-01-20 9:37 ` [PATCH net-next v3 6/7] mlxsw: ethtool: Pass link mode in use to ethtool Danielle Ratson
2021-01-20 9:37 ` [PATCH net-next v3 7/7] net: selftests: Add lanes setting test Danielle Ratson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKOOJTw75uLVPpzV1a85SFsO7Gz9bcfS9M1CWHQONCfMLC4H6g@mail.gmail.com \
--to=edwin.peer@broadcom.com \
--cc=andrew@lunn.ch \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).