From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f196.google.com ([209.85.216.196]:41627 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbeBYWha (ORCPT ); Sun, 25 Feb 2018 17:37:30 -0500 Received: by mail-qt0-f196.google.com with SMTP id j4so1772394qth.8 for ; Sun, 25 Feb 2018 14:37:29 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20180224012036.5834-4-vinicius.gomes@intel.com> References: <20180224012036.5834-1-vinicius.gomes@intel.com> <20180224012036.5834-4-vinicius.gomes@intel.com> From: Alexander Duyck Date: Sun, 25 Feb 2018 14:37:28 -0800 Message-ID: Subject: Re: [Intel-wired-lan] [next-queue PATCH 3/8] igb: Enable the hardware traffic class feature bit for igb models To: Vinicius Costa Gomes Cc: intel-wired-lan , Netdev , Jesus Sanchez-Palencia Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Feb 23, 2018 at 5:20 PM, Vinicius Costa Gomes wrote: > This will allow functionality depending on the hardware being traffic > class aware to work. In particular the tc-flower offloading checks > verifies that this bit is set. > > Signed-off-by: Vinicius Costa Gomes > --- > drivers/net/ethernet/intel/igb/igb_main.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c > index 0ea32be07d71..543aa99892eb 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -2820,8 +2820,10 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > NETIF_F_HW_VLAN_CTAG_TX | > NETIF_F_RXALL; > > - if (hw->mac.type >= e1000_i350) > - netdev->hw_features |= NETIF_F_NTUPLE; > + if (hw->mac.type >= e1000_i350) { > + netdev->hw_features |= (NETIF_F_NTUPLE | NETIF_F_HW_TC); > + netdev->features |= NETIF_F_HW_TC; The parens aren't needed. Also you might consider moving this block up to where we have a similar one for 82576. Then you wouldn't need to set both features and hw_features in the case of the HW_TC flag. > + } > > if (pci_using_dac) > netdev->features |= NETIF_F_HIGHDMA; > -- > 2.16.2 > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan