From: Steve Glendinning <steve@shawell.net>
To: Joe Perches <joe@perches.com>
Cc: netdev <netdev@vger.kernel.org>, David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/2] smsc75xx: support PHY wakeup source
Date: Tue, 27 Nov 2012 17:23:15 +0000 [thread overview]
Message-ID: <CAKh2mn4xfpO-vMZGnikuS29xrCc_XJMGu0gexyn1EBeG4prgog@mail.gmail.com> (raw)
In-Reply-To: <1354031804.2116.8.camel@joe-AO722>
Hi Joe,
On 27 November 2012 15:56, Joe Perches <joe@perches.com> wrote:
> On Tue, 2012-11-27 at 14:28 +0000, Steve Glendinning wrote:
>> + ret = smsc75xx_read_reg_nopm(dev, PMT_CTL, &val);
>> + check_warn_return(ret, "Error reading PMT_CTL");
>
> Hi Steve, can you please add newlines to these new
> check_warn_<foo> messages and the netdev_<level> ones too?
> It helps avoid message interleaving.
Sorry about that, I did see your earlier patch to fix existing instances.
David: please discard this patch too, I'll resubmit.
prev parent reply other threads:[~2012-11-27 17:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 14:28 [PATCH 0/2] smsc75xx enhancements Steve Glendinning
2012-11-27 14:28 ` [PATCH 1/2] smsc75xx: refactor entering suspend modes Steve Glendinning
[not found] ` <1354026482-10443-2-git-send-email-steve.glendinning-nksJyM/082jR7s880joybQ@public.gmane.org>
2012-11-27 14:50 ` Bjørn Mork
[not found] ` <87624r9k1f.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2012-11-27 17:21 ` Steve Glendinning
2012-11-27 17:55 ` Steve Glendinning
[not found] ` <CAKh2mn7f94a7La_EQ9L_qwr7FZEXfawUiAajPMDO8ScS2fJupg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-27 18:12 ` Bjørn Mork
2012-11-27 19:46 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1211271443150.1489-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-11-28 8:34 ` Steve Glendinning
2012-11-28 9:31 ` Bjørn Mork
2012-11-28 10:16 ` Steve Glendinning
2012-11-28 11:42 ` Bjørn Mork
[not found] ` <87k3t62btw.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2012-11-28 12:43 ` Steve Glendinning
2012-11-28 12:57 ` Bjørn Mork
2012-11-28 17:16 ` Steve Glendinning
2012-11-27 14:28 ` [PATCH 2/2] smsc75xx: support PHY wakeup source Steve Glendinning
2012-11-27 15:56 ` Joe Perches
2012-11-27 17:23 ` Steve Glendinning [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKh2mn4xfpO-vMZGnikuS29xrCc_XJMGu0gexyn1EBeG4prgog@mail.gmail.com \
--to=steve@shawell.net \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).