From: Rami Rosen <roszenrami@gmail.com>
To: Iyappan Subramanian <isubramanian@apm.com>
Cc: David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
andrew@lunn.ch, Florian Fainelli <f.fainelli@gmail.com>,
David.Laight@aculab.com, linux-arm-kernel@lists.infradead.org,
patches@apm.com, kchudgar@apm.com
Subject: Re: [PATCH v4 net-next 4/6] drivers: net: xgene-v2: Add base driver
Date: Wed, 8 Mar 2017 05:43:04 +0200 [thread overview]
Message-ID: <CAKoUArkOj-RvWZB-Gy6GC2C3yHFvsEGgoauQcAxYhBAurdjH0A@mail.gmail.com> (raw)
In-Reply-To: <1488935325-13603-5-git-send-email-isubramanian@apm.com>
Hi,
One minor comment:
The return type of xge_init_hw() should be changed to be void, as
the method xge_port_reset() always returns 0; and also the return type
of xge_port_reset() should be changed to be void, it never fails; see
in [PATCH v4 net-next 3/6] drivers: net: xgene-v2: Add ethernet
hardware configuration.
+static int xge_init_hw(struct net_device *ndev)
+{
+ struct xge_pdata *pdata = netdev_priv(ndev);
+ int ret;
+
+ ret = xge_port_reset(ndev);
+ if (ret)
+ return ret;
+
+ xge_port_init(ndev);
+ pdata->nbufs = NUM_BUFS;
+
+ return 0;
+}
Regards,
Rami Rosen
next prev parent reply other threads:[~2017-03-08 3:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 1:08 [PATCH v4 net-next 0/6] drivers: net: xgene-v2: Add RGMII based 1G driver Iyappan Subramanian
2017-03-08 1:08 ` [PATCH v4 net-next 1/6] drivers: net: xgene-v2: Add DMA descriptor Iyappan Subramanian
2017-03-08 1:08 ` [PATCH v4 net-next 2/6] drivers: net: xgene-v2: Add mac configuration Iyappan Subramanian
2017-03-08 1:08 ` [PATCH v4 net-next 3/6] drivers: net: xgene-v2: Add ethernet hardware configuration Iyappan Subramanian
2017-03-08 1:08 ` [PATCH v4 net-next 4/6] drivers: net: xgene-v2: Add base driver Iyappan Subramanian
2017-03-08 1:22 ` Florian Fainelli
2017-03-08 3:43 ` Rami Rosen [this message]
2017-03-08 1:08 ` [PATCH v4 net-next 5/6] drivers: net: xgene-v2: Add transmit and receive Iyappan Subramanian
2017-03-08 1:08 ` [PATCH v4 net-next 6/6] MAINTAINERS: Add entry for APM X-Gene SoC Ethernet (v2) driver Iyappan Subramanian
2017-03-09 21:25 ` [PATCH v4 net-next 0/6] drivers: net: xgene-v2: Add RGMII based 1G driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKoUArkOj-RvWZB-Gy6GC2C3yHFvsEGgoauQcAxYhBAurdjH0A@mail.gmail.com \
--to=roszenrami@gmail.com \
--cc=David.Laight@aculab.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=isubramanian@apm.com \
--cc=kchudgar@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=patches@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).