From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E7D9C3A59F for ; Tue, 27 Aug 2019 00:20:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3ACF206BB for ; Tue, 27 Aug 2019 00:19:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rlLf2ah1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727633AbfH0AT4 (ORCPT ); Mon, 26 Aug 2019 20:19:56 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:42478 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbfH0ATz (ORCPT ); Mon, 26 Aug 2019 20:19:55 -0400 Received: by mail-pg1-f193.google.com with SMTP id p3so11560969pgb.9 for ; Mon, 26 Aug 2019 17:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hEEzzkdeRsczZgOxP6fZZQbk+BsAjtf5i89GMJdNvlE=; b=rlLf2ah1lkpxv0U4sCKox8teYypFOsXhPw8Tiz+SNCVDdyx4vxv9LfOgcNYsNS+y83 Yg8HzPGc8JUgeBKk3Y2PX+C6aGW6qoUtel5U5CIfMXnlcd+S/IBtU0XpZ+qJ/JOjxarD j/OE/JjfpvfD8gTDgShCI4D93Zslm+cAAMdMy5AuO8bY0ovqd1N4Eeqw/ZZsB+cV9KZk E95+VcgDt12U1PKk6YwfKBE5UyiBXuEZffnmHhZNAIc1BMj+PhulPKqKi9XAS5AhiLce gMt9DGZc8pfbPA6NP32hvvW4qr5XdG4+KzQDbnE6bP2somHVDqq+XLFb24EFtCnMTeMn gJaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hEEzzkdeRsczZgOxP6fZZQbk+BsAjtf5i89GMJdNvlE=; b=dxefhKkE17uMu/7I3ifY6/fAs9T+nw2iCKnmrec/8IO7iz+ZNSjAZbniHjxVEQROOi +++rGEegrSVEXMZSNfPqdENztM4vZwDODdkgGJHplfXrZiqo3u3zLf/IggPL48MDRr0a SMXoNW/xr61Cnd7e/yOB01gmxE6h5hwkF2E/3ETTh1bLaRwb4heTv2VgYeiP183MpEqd 2OfqvuIpFR+7au7vnlseD9kvtZIIVltYXgiINQNIXw2bFWtvNCGRCdPDhyRcbDwPaN01 34Qq8w9+vGg/Qr6QtpO5asmls/TG4Z4P+0FW4S2739N+RtzDXcP0bXi4/bSfnkLA3QiV LJLA== X-Gm-Message-State: APjAAAVOAAmxieMEKLKeVrVjuL1Mo5fpB02gbvV4vLHiuM+1mQda8T49 0Q6oMOyFq58bk7BqIJ+1RVvdZRX64DpUv7b5PDG/+A== X-Google-Smtp-Source: APXvYqxHnCdlzUczP/jzH7EyDlrfTM8SgWVtE5IiAWt81GfWcFP3LsN64bL6ZIOrHbsimWRUCdvbNDymaO/b10v3kbg= X-Received: by 2002:aa7:8085:: with SMTP id v5mr21870548pff.165.1566865194432; Mon, 26 Aug 2019 17:19:54 -0700 (PDT) MIME-Version: 1.0 References: <20190812215052.71840-1-ndesaulniers@google.com> <20190812215052.71840-8-ndesaulniers@google.com> <20190815093848.tremcmaftzspuzzj@pburton-laptop> In-Reply-To: <20190815093848.tremcmaftzspuzzj@pburton-laptop> From: Nick Desaulniers Date: Mon, 26 Aug 2019 17:19:43 -0700 Message-ID: Subject: Re: [PATCH 08/16] mips: prefer __section from compiler_attributes.h To: Paul Burton Cc: "akpm@linux-foundation.org" , "sedat.dilek@gmail.com" , "jpoimboe@redhat.com" , "yhs@fb.com" , "miguel.ojeda.sandonis@gmail.com" , "clang-built-linux@googlegroups.com" , Ralf Baechle , James Hogan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , "linux-mips@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Aug 15, 2019 at 2:38 AM Paul Burton wrote: > > Hi Nick, > > On Mon, Aug 12, 2019 at 02:50:41PM -0700, Nick Desaulniers wrote: > > Reported-by: Sedat Dilek > > Suggested-by: Josh Poimboeuf > > Signed-off-by: Nick Desaulniers > > It would be good to add a commit message, even if it's just a line > repeating the subject & preferably describing the motivation. > > > --- > > arch/mips/include/asm/cache.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/mips/include/asm/cache.h b/arch/mips/include/asm/cache.h > > index 8b14c2706aa5..af2d943580ee 100644 > > --- a/arch/mips/include/asm/cache.h > > +++ b/arch/mips/include/asm/cache.h > > @@ -14,6 +14,6 @@ > > #define L1_CACHE_SHIFT CONFIG_MIPS_L1_CACHE_SHIFT > > #define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT) > > > > -#define __read_mostly __attribute__((__section__(".data..read_mostly"))) > > +#define __read_mostly __section(.data..read_mostly) > > > > #endif /* _ASM_CACHE_H */ > > -- > > 2.23.0.rc1.153.gdeed80330f-goog > > I'm not copied on the rest of the series so I'm not sure what your > expectations are about where this should be applied. Let me know if > you'd prefer this to go through mips-next, otherwise: > > Acked-by: Paul Burton Thanks Paul, going to send this up via Miguel's tree, if you don't mind. Updating my series now. (Will probably avoid running get_maintainer.pl on every patch...too hard to cc everyone on the whole series). -- Thanks, ~Nick Desaulniers