From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 938D9134C4 for ; Tue, 11 Jun 2024 02:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718071584; cv=none; b=KdHcJ2K5fk4+QrVM5F5syZR+9ZpnlYrjEwJTznfG0SRAcVw5YCZOEoEJhW0Mdx+gosuN76kmYv5/4ReTGnrBJ/c9F5uB3N01/OJas/RliodsGrZjgYMyaYqCtvaIMj4o9fWuenGYKTlyjaMqF+w6+4G0T98cli8pwW0U9ZOxYlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718071584; c=relaxed/simple; bh=tuff/6OuEt+2hme3SS1LRX+ueYVQOYk0iMP38yw56OQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=kSy9vN95UqzhM9UoyPFFvnQ5H1O+aWTiSPOcEBe7kvRuiivRmxUYXfwJODFJ/EnRfyReyBq8EU4HIYWNSQdWjlJjw296U82qfH7eJwfetVvxuKWhMgV1eWzTT2MsZFJbd6igjfEEEiUGSjSZsTSML9rJhp0qrY/A4lnkLeRJL+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AYwZmOf4; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AYwZmOf4" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a6265d3ba8fso503522166b.0 for ; Mon, 10 Jun 2024 19:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718071581; x=1718676381; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tuff/6OuEt+2hme3SS1LRX+ueYVQOYk0iMP38yw56OQ=; b=AYwZmOf4EV0VFoOHdFHLSwJaZX9ZV+Zs2yA/FWwYn8+xDwYRn23R4+A/EYJUY8Kp1x lZ62mVYcLTrR06Aec9zlMCxCxO/C7DHVI5VgiLdAjH18HSgPxfqmnQT6tu7vhP93yjKt Gma66EjonVzVw4Y+uKMlRf2FYOCnfVdyMPluP+Xt/KuqAkQZ9IlHFjK9ctHCvrbTZN3B woexZ267zH9Pm6Ik3xMt/pgAP2MxR3AP4F2uHjPUuG8dYefHW/crc+/Nf5WPKKe2NSgv Y9AafY9e0iItmLBcj0w3tEkWHSsIBPZMyqzI+7DnXMzuuVAms2pGAjHIBlt7/EDynbLd 3KCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718071581; x=1718676381; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tuff/6OuEt+2hme3SS1LRX+ueYVQOYk0iMP38yw56OQ=; b=kZoro+DQFXpwfEydIekaS67ZsBvDs68otxcB7erS61kM2v4s8jpjdnXqxfbQ9hfJ/b CBIN+iXIwwBtnb/K+cpccMauYx6ORuxfj9OIYpg1ZZYEowb1hAWCqyubD7ZsLwjUsK6e tE2VsY83GUwo5ALUgrii3IQTSpTg1aSNZr03TXhYgZqdgfzxuN0pXqckXuiIHh9U/xN4 1SyvFhorFB15DBKSDDqI/M5HqDEFGg8OQNCexfDZKGcQNftnLn8rC8pCsHgA31QQHyZc Ho5dPKAEeTENO2B2xTdKhK0dCUp8D+Us1mud52M/zEKwmc0+SDHgn9/1mcGcKGF2fnpA mu4Q== X-Forwarded-Encrypted: i=1; AJvYcCVVllkzvnTIylV9+H5fUUqYTNEerAHakwRBa6CyM1/UBX/Ah3SZ+z2v3ROl60F+08KdZI3gRSW1dbPZbTSvvr+ppT8pn10t X-Gm-Message-State: AOJu0Yw2Jk4K2WHiw+0eRIQyKfOqU+lY4lRot1wafNur/VVmEo0ozcFn cqR3JloTmjx/jQlObL+qTC8EqferdQYa1SYDa0fOjL+/4+aJ8MxCcvBkL3os0cbEQb0vZOijX2f NxoCLT+EwLvEeVcEbv5ED7q9CMnY= X-Google-Smtp-Source: AGHT+IHJ8AjC2nQdCHkvEIiAg5SYB3Vy4VBsSouM+tmUNPm4sUIJZMgWBTWyiI1mjy8d9yBV3+j6xZozdhfUDe7nhgY= X-Received: by 2002:a17:907:7f87:b0:a6f:20af:49cb with SMTP id a640c23a62f3a-a6f20af4f9dmr298552066b.48.1718071580627; Mon, 10 Jun 2024 19:06:20 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240130142521.18593-1-danielj@nvidia.com> <20240130095645-mutt-send-email-mst@kernel.org> <20240130104107-mutt-send-email-mst@kernel.org> <20240130105246-mutt-send-email-mst@kernel.org> <20240201202106.25d6dc93@kernel.org> <20240202080126.72598eef@kernel.org> <20240610105717.7fbb1caa@kernel.org> In-Reply-To: <20240610105717.7fbb1caa@kernel.org> From: Jason Xing Date: Tue, 11 Jun 2024 10:05:41 +0800 Message-ID: Subject: Re: [PATCH net-next] virtio_net: Add TX stop and wake counters To: Jakub Kicinski Cc: Dan Jurgens , "Michael S. Tsirkin" , "netdev@vger.kernel.org" , "jasowang@redhat.com" , "xuanzhuo@linux.alibaba.com" , "virtualization@lists.linux.dev" , "davem@davemloft.net" , "edumazet@google.com" , "abeni@redhat.com" , Parav Pandit Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 11, 2024 at 1:57=E2=80=AFAM Jakub Kicinski wr= ote: > > On Sat, 8 Jun 2024 08:41:44 +0800 Jason Xing wrote: > > > > Sorry to revive this thread. I wonder why not use this patch like m= lnx driver > > > > does instead of adding statistics into the yaml file? Are we gradua= lly using or > > > > adding more fields into the yaml file to replace the 'ethtool -S' c= ommand? > > > > > > > > > > It's trivial to have the stats in ethtool as well. But I noticed > > > the stats series intentionally removed some stats from ethtool. So > > > I didn't put it both places. > > > > Thank you for the reply. I thought there was some particular reason > > :-) > > Yes, we don't want duplication. We have a long standing (and > documented) policy against duplicating normal stats in custom stat > APIs, otherwise vendors pile everything into the custom stats. Thanks, Jakub. I see :)