From: Jason Xing <kerneljasonxing@gmail.com>
To: Hillf Danton <hdanton@sina.com>
Cc: pabeni@redhat.com, Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net] net: fix raising a softirq on the current cpu with rps enabled
Date: Sun, 26 Mar 2023 11:30:45 +0800 [thread overview]
Message-ID: <CAL+tcoCO47mgZeKM=h8OZWcebB-hKzyC9FiTgs2cPR25bE18UQ@mail.gmail.com> (raw)
In-Reply-To: <20230326013845.2110-1-hdanton@sina.com>
On Sun, Mar 26, 2023 at 9:39 AM Hillf Danton <hdanton@sina.com> wrote:
>
> On Sat, Mar 25, 2023 at 8:26 AM Jason Xing <kerneljasonxing@gmail.com>
> >
> > @@ -4594,8 +4594,6 @@ static int napi_schedule_rps(struct softnet_data *sd)
> > if (sd !=3D mysd) {
> > sd->rps_ipi_next =3D mysd->rps_ipi_list;
> > mysd->rps_ipi_list =3D sd;
> > -
> > - __raise_softirq_irqoff(NET_RX_SOFTIRQ);
> > return 1;
> > }
>
> Nope, ipi should be sent. But no ipi can go without irq enabled.
>
Sorry, I didn't get it. IPI is sent in net_rx_action() and apparently
I didn't touch this part in this patch. Here is only about whether we
should raise an IRQ even if the skb will be enqueued into another cpu.
> So feel free to work out what sense made by disabling irq at the call site
> then directly send ipi instead.
prev parent reply other threads:[~2023-03-26 3:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 15:24 [PATCH net] net: fix raising a softirq on the current cpu with rps enabled Jason Xing
2023-03-25 15:56 ` Eric Dumazet
2023-03-26 3:27 ` Jason Xing
2023-03-26 4:04 ` Jason Xing
2023-03-26 10:10 ` Jason Xing
2023-03-26 14:56 ` Jason Xing
2023-03-26 17:35 ` Eric Dumazet
2023-03-27 2:25 ` Jason Xing
[not found] ` <20230326013845.2110-1-hdanton@sina.com>
2023-03-26 3:30 ` Jason Xing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL+tcoCO47mgZeKM=h8OZWcebB-hKzyC9FiTgs2cPR25bE18UQ@mail.gmail.com' \
--to=kerneljasonxing@gmail.com \
--cc=edumazet@google.com \
--cc=hdanton@sina.com \
--cc=kernelxing@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).