Re: [PATCH net-next v8 08/10] tcp: add dropreasons in tcp_rcv_state_process()

[Jason Xing <kerneljasonxing@gmail.com>]

On Fri, Feb 23, 2024 at 1:28 AM David Ahern <dsahern@kernel.org> wrote:
>
> On 2/22/24 4:30 AM, Jason Xing wrote:
> > @@ -6704,8 +6705,13 @@ int tcp_rcv_state_process(struct sock *sk, struct sk_buff *skb)
> >                                 FLAG_NO_CHALLENGE_ACK);
> >
> >       if ((int)reason <= 0) {
> > -             if (sk->sk_state == TCP_SYN_RECV)
> > -                     return 1;       /* send one RST */
> > +             if (sk->sk_state == TCP_SYN_RECV) {
> > +                     /* send one RST */
> > +                     if (!reason)
> > +                             return SKB_DROP_REASON_TCP_OLD_ACK;
> > +                     else
> > +                             return -reason;
>
> checkpatch should be flagging this - the `else` is not needed.

Maybe the way I use the checkpatch script is not right...

>
>                         if (!reason)
>                                 return SKB_DROP_REASON_TCP_OLD_ACK;
>
>                         return -reason;
>
>

Thanks, I will update it.