From: Jason Xing <kerneljasonxing@gmail.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, netdev@vger.kernel.org,
magnus.karlsson@intel.com, stfomichev@gmail.com
Subject: Re: [PATCH v2 bpf-next 2/3] xsk: remove @first_frag from xsk_build_skb()
Date: Fri, 26 Sep 2025 08:09:10 +0800 [thread overview]
Message-ID: <CAL+tcoCcdPYwrCUvnRFspH4CZOmia99XaW2sSe-CiGbNErnmkQ@mail.gmail.com> (raw)
In-Reply-To: <20250925160009.2474816-3-maciej.fijalkowski@intel.com>
On Fri, Sep 26, 2025 at 12:00 AM Maciej Fijalkowski
<maciej.fijalkowski@intel.com> wrote:
>
> Instead of using auxiliary boolean that tracks if we are at first frag
> when gathering all elements of skb, same functionality can be achieved
> with checking if skb_shared_info::nr_frags is 0.
>
> Remove @first_frag but be careful around xsk_build_skb_zerocopy() and
> NULL the skb pointer when it failed so that common error path does not
> incorrectly interpret it during decision whether to call kfree_skb().
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
next prev parent reply other threads:[~2025-09-26 0:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 16:00 [PATCH v2 bpf-next 0/3] xsk: refactors around generic xmit side Maciej Fijalkowski
2025-09-25 16:00 ` [PATCH v2 bpf-next 1/3] xsk: avoid overwriting skb fields for multi-buffer traffic Maciej Fijalkowski
2025-09-25 18:28 ` Stanislav Fomichev
2025-09-25 23:45 ` Jason Xing
2025-09-25 16:00 ` [PATCH v2 bpf-next 2/3] xsk: remove @first_frag from xsk_build_skb() Maciej Fijalkowski
2025-09-25 18:28 ` Stanislav Fomichev
2025-09-26 0:09 ` Jason Xing [this message]
2025-09-25 16:00 ` [PATCH v2 bpf-next 3/3] xsk: wrap generic metadata handling onto separate function Maciej Fijalkowski
2025-09-26 19:48 ` [PATCH v2 bpf-next 0/3] xsk: refactors around generic xmit side Martin KaFai Lau
2025-09-26 20:54 ` Jakub Kicinski
2025-09-26 21:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL+tcoCcdPYwrCUvnRFspH4CZOmia99XaW2sSe-CiGbNErnmkQ@mail.gmail.com \
--to=kerneljasonxing@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).