From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA6C326ACB for ; Fri, 26 Sep 2025 00:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758845389; cv=none; b=bEJ9eJsekJP/iQ45FIhNg/obMS5RKhTMFg5ivVmsyZwmMx4kouxNXRWkElHGsm6EpFV39vIpTHvskR6EDQVBHrApINPjS/9zO9EaejgfVcsJX7t0lL7pO68SGAr8HmGbEy7c6rUL25ra6XH6+liI3NPz/+0Zx+BenIKNwIIcRWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758845389; c=relaxed/simple; bh=EcF3KEFlgcW+csVv+7/3Ly5TOD8RBUoCKU9/CtUnizk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=XXtodeIxN3quAdwsL6Jx1nemyfDDakAa3YHOFEuTbrHTNafn3GxrsUwwHmEBgWX4Di5gZlxLoCdl5QD8r7Fk8aHqpJ2toSv0PR9MOQcJU1wFVHPYZqWJSlfTPRSQXZz+VsfNGnOPqZvfNSavc68unYXgmXw7awb3G1xYz1tpsb0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bHRmN9zg; arc=none smtp.client-ip=209.85.166.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bHRmN9zg" Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-4242bb22132so13644195ab.3 for ; Thu, 25 Sep 2025 17:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758845387; x=1759450187; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EcF3KEFlgcW+csVv+7/3Ly5TOD8RBUoCKU9/CtUnizk=; b=bHRmN9zge+PsOxGdMRb5SR1VLuBIWJpnT/VfGT6pOyQWkRX7IjyRiXHvqjv7ddI0lN qOmYCjEpkSjyNM5CuN2tnqJMwHYFGN4Lr9l2irfFbXIOBpSohqw6VrVk93BabCBE308K Xao6k+tYz/boDMalIHPtu+FNI9voa6R3BUhBbIjxReH51xLpJF/8/7viOqqYnoapWd8g KFn8ZWqfvNj9Dw2EgyexLYCvQx9LGJf07KWmQ3isrIRRAezUj6u+Q//ujXDxo/ur+zMN bSlTxN8TCuiuz3QDCQXMiO46l9Y8JRM+rG50SxfesAnR/zcezUOoG624YFz8VV0s3YOX rA8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758845387; x=1759450187; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EcF3KEFlgcW+csVv+7/3Ly5TOD8RBUoCKU9/CtUnizk=; b=b7zYGB7kiJLObuX7EoQ3WBDvH0ZbYFHQrM1QThdVjpR1jyVxNZpwaW2TiJS/gHCNXr joLAv7QVnWLB6zzTgss3Z5OtoM5eIp/ci//9pNCZ0NtYvyNuEvOKEFQ0+C7QXE/z2IcN h6iJRGdQCWHPpkxs7+qgD3ldx/YfGv/hql4H8eku7npYAdkVWCQln2eydahS0VJ2SPLy MF8QNJw/nhssQKUwrEHA4+utysQDgFGFZMGg8v+1yaxyGzyJJ2/WdCz8g6kGTIHugHED 7TfdEEvBEe9E5vn/ujqFB3EEFGwFtUDSjBh2JQwFe43L9yUsMIy/fSH6aU8Crn7BNwb9 84jA== X-Forwarded-Encrypted: i=1; AJvYcCXeYbetGqyc+RctN3O2ZPR/KE2ws9WKLzwBvXWJG+ZnzpOrFPvurLpWU8pp3zYqK42m8dlUPAQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwaFZ+OYzxf6AnfGnZzsfaag9LuKpPueN31xHLxjKc9tlEPytOu xf2cyLpy8vbsbPneo49CBTSzq36GXBKXFG5DN14888akVvL1Mz1K7RgH8reD3bBH7HepGXEscRQ MC0FkzUHYFQBJ2LPijSKKpqBgC56qORvMqYs8Kn1dNw== X-Gm-Gg: ASbGnctrZfgQEy9vZzh2MQx8dXtmUyPQnI+UoEaiJ3OZ2Ik0gTuB6Z87uwyrK7ijxms bDZFPZ3E7UefVVTk8vRhLDnxP4+eJDV3E+vjTDjHIz4MAz4vcTw8fmvv9SQWfbRhlRUHON+KwDU wESHiQt5LUGAog2Cl/PqOD3AxidZFejLhjubtceebwDWFEbv8LQsZE30zS/yFyxplWUXsmTSWlm 9KSyg== X-Google-Smtp-Source: AGHT+IEdUfwwxztT3hV1YzT7LIX8Z/JTiGmIH0ncgWo3wXZ3rUzN62zQT1aEcss1YIZCIF37iemyiaId0M3moPjmW8w= X-Received: by 2002:a92:d08c:0:b0:425:8744:de9b with SMTP id e9e14a558f8ab-42595614302mr60924005ab.18.1758845386799; Thu, 25 Sep 2025 17:09:46 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250925160009.2474816-1-maciej.fijalkowski@intel.com> <20250925160009.2474816-3-maciej.fijalkowski@intel.com> In-Reply-To: <20250925160009.2474816-3-maciej.fijalkowski@intel.com> From: Jason Xing Date: Fri, 26 Sep 2025 08:09:10 +0800 X-Gm-Features: AS18NWDQyjm8xJcDxkGLPrUwJvdPtkzVnU_2eax4yonamiagMhSPnDncCAnnd1M Message-ID: Subject: Re: [PATCH v2 bpf-next 2/3] xsk: remove @first_frag from xsk_build_skb() To: Maciej Fijalkowski Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, netdev@vger.kernel.org, magnus.karlsson@intel.com, stfomichev@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Sep 26, 2025 at 12:00=E2=80=AFAM Maciej Fijalkowski wrote: > > Instead of using auxiliary boolean that tracks if we are at first frag > when gathering all elements of skb, same functionality can be achieved > with checking if skb_shared_info::nr_frags is 0. > > Remove @first_frag but be careful around xsk_build_skb_zerocopy() and > NULL the skb pointer when it failed so that common error path does not > incorrectly interpret it during decision whether to call kfree_skb(). > > Signed-off-by: Maciej Fijalkowski Reviewed-by: Jason Xing