netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Xing <kerneljasonxing@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>,
	Neal Cardwell <ncardwell@google.com>,
	 Simon Horman <horms@kernel.org>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	netdev@vger.kernel.org,  eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 2/3] selftests/net: packetdrill: add tcp_close_no_rst.pkt
Date: Thu, 4 Sep 2025 14:20:34 +0800	[thread overview]
Message-ID: <CAL+tcoDLLknDrzbiStcPH+Wwniv1W1eRVBWLo59KdyJVxNaXvA@mail.gmail.com> (raw)
In-Reply-To: <20250903084720.1168904-3-edumazet@google.com>

On Wed, Sep 3, 2025 at 4:47 PM Eric Dumazet <edumazet@google.com> wrote:
>
> This test makes sure we do send a FIN on close()
> if the receive queue contains data that was consumed.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Thanks for spotting this interesting case.

Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>

Thanks,
Jason

  parent reply	other threads:[~2025-09-04  6:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03  8:47 [PATCH net-next 0/3] tcp: __tcp_close() changes Eric Dumazet
2025-09-03  8:47 ` [PATCH net-next 1/3] tcp: fix __tcp_close() to only send RST when required Eric Dumazet
2025-09-03 15:07   ` Neal Cardwell
2025-09-03 18:28     ` Kuniyuki Iwashima
2025-09-04  5:03   ` Jason Xing
2025-09-04  5:31     ` Kuniyuki Iwashima
2025-09-04  6:19       ` Jason Xing
2025-09-04  6:44         ` Eric Dumazet
2025-09-04  6:49           ` Jason Xing
2025-09-03  8:47 ` [PATCH net-next 2/3] selftests/net: packetdrill: add tcp_close_no_rst.pkt Eric Dumazet
2025-09-03 15:08   ` Neal Cardwell
2025-09-03 18:28     ` Kuniyuki Iwashima
2025-09-04  6:20   ` Jason Xing [this message]
2025-09-03  8:47 ` [PATCH net-next 3/3] tcp: use tcp_eat_recv_skb in __tcp_close() Eric Dumazet
2025-09-03 15:09   ` Neal Cardwell
2025-09-03 18:30     ` Kuniyuki Iwashima
2025-09-04  6:34   ` Jason Xing
2025-09-05  2:20 ` [PATCH net-next 0/3] tcp: __tcp_close() changes patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL+tcoDLLknDrzbiStcPH+Wwniv1W1eRVBWLo59KdyJVxNaXvA@mail.gmail.com \
    --to=kerneljasonxing@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).