From: Roland Dreier <roland@purestorage.com>
To: David Miller <davem@davemloft.net>
Cc: johnwheffner@gmail.com, mj@ucw.cz, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ipv4: Use universal hash for ARP.
Date: Wed, 13 Jul 2011 10:59:08 -0700 [thread overview]
Message-ID: <CAL1RGDWXqnL4zzcfV_kj=R2P148JcVB2X2QUV90__+e5zUH-cQ@mail.gmail.com> (raw)
In-Reply-To: <20110711.014845.1009062692530385177.davem@davemloft.net>
On Mon, Jul 11, 2011 at 1:48 AM, David Miller <davem@davemloft.net> wrote:
> +static inline u32 arp_hashfn(u32 key, const struct net_device *dev, u32 hash_rnd)
> +{
> + u32 val = key ^ dev->ifindex;
> +
> + return val * hash_rnd;
> +}
OK, I suggested this, and there's nothing obviously wrong with it.
But I would hope that someone actually vetted that this provides
enough variation between different hash_rnd values to avoid hash
chain attacks.
- R.
prev parent reply other threads:[~2011-07-13 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 8:48 [PATCH 2/2] ipv4: Use universal hash for ARP David Miller
2011-07-13 17:59 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1RGDWXqnL4zzcfV_kj=R2P148JcVB2X2QUV90__+e5zUH-cQ@mail.gmail.com' \
--to=roland@purestorage.com \
--cc=davem@davemloft.net \
--cc=johnwheffner@gmail.com \
--cc=mj@ucw.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).