From: Matthew Hagan <mnhagan88@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: sfp: Add tx-fault quirk for Huawei MA5671A SFP ONT
Date: Mon, 2 May 2022 23:32:51 +0100 [thread overview]
Message-ID: <CAL3BVdq-OkoJM8LEXvJLW8HS3n8-VH3KrM-A8CbjUm9SC3r3vw@mail.gmail.com> (raw)
In-Reply-To: <YnAlBvWyyJ9oDcpz@lunn.ch>
On Mon, 2 May 2022 at 19:37, Andrew Lunn <andrew@lunn.ch> wrote:
>
> > + if (!memcmp(id.base.vendor_name, "HUAWEI ", 16) &&
> > + !memcmp(id.base.vendor_pn, "MA5671A ", 16))
> > + sfp->tx_fault_ignore = true;
> > + else
> > + sfp->tx_fault_ignore = false;
> > +
> > + return 0;
> > +
> > return 0;
>
> Why do we need two return 0; Probably a merged conflict gone wrong.
>
Apologies for the oversight. Will submit a v2 shortly.
> Andrew
Matthew
prev parent reply other threads:[~2022-05-02 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 12:48 [PATCH] net: sfp: Add tx-fault quirk for Huawei MA5671A SFP ONT Matthew Hagan
2022-05-02 18:37 ` Andrew Lunn
2022-05-02 22:32 ` Matthew Hagan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL3BVdq-OkoJM8LEXvJLW8HS3n8-VH3KrM-A8CbjUm9SC3r3vw@mail.gmail.com \
--to=mnhagan88@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).