netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 10/17] net: igb calls skb_set_rxhash
@ 2013-11-26 17:31 Tom Herbert
  2013-11-26 21:51 ` Jeff Kirsher
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Herbert @ 2013-11-26 17:31 UTC (permalink / raw)
  To: netdev, davem

Drivers should call skb_set_rxhash to set the rxhash and its type
in an skbuff.

Signed-off-by: Tom Herbert <therbert@google.com>
---
 drivers/net/ethernet/intel/igb/igb_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index ebe6370..4e8e2b2 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -6412,7 +6412,9 @@ static inline void igb_rx_hash(struct igb_ring *ring,
 			       struct sk_buff *skb)
 {
 	if (ring->netdev->features & NETIF_F_RXHASH)
-		skb->rxhash = le32_to_cpu(rx_desc->wb.lower.hi_dword.rss);
+		skb_set_rxhash(skb,
+			       le32_to_cpu(rx_desc->wb.lower.hi_dword.rss),
+			       RXHASH_TYPE_L3);
 }
 
 /**
-- 
1.8.4.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 10/17] net: igb calls skb_set_rxhash
  2013-11-26 17:31 [PATCH v2 10/17] net: igb calls skb_set_rxhash Tom Herbert
@ 2013-11-26 21:51 ` Jeff Kirsher
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Kirsher @ 2013-11-26 21:51 UTC (permalink / raw)
  To: Tom Herbert; +Cc: netdev, David Miller

On Tue, Nov 26, 2013 at 9:31 AM, Tom Herbert <therbert@google.com> wrote:
> Drivers should call skb_set_rxhash to set the rxhash and its type
> in an skbuff.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

I have added the patch to my queue, thanks Tom!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-11-26 21:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-26 17:31 [PATCH v2 10/17] net: igb calls skb_set_rxhash Tom Herbert
2013-11-26 21:51 ` Jeff Kirsher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).