netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Barnhill <0xeffeff@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: v6/sit tunnels and VRFs
Date: Sat, 14 Apr 2018 18:07:50 -0400	[thread overview]
Message-ID: <CAL6e_pepzeTXMboH-OKGyfevoXFJWZThbT-qR8kx9vFXtmxm1Q@mail.gmail.com> (raw)
In-Reply-To: <e19f2fb3-319c-e8ea-5fc3-5072ddb69c5b@gmail.com>

I didn't see an easy way to achieve this behavior without affecting
the non-VRF routing lookups (such as deleting non-VRF rules).  We have
some automated tests that were looking for specific responses, but, of
course, those can be changed.  Among a few of my colleagues, this
became a discussion about maintaining consistent behavior between VRF
and non-VRF, such that a ping or some other tool wouldn't respond
differently.  That's the main reason I asked the question here - to
see how important this was in general use. It sounds like in your
experience, the specific error message/code hasn't been an issue.

Thanks,
Jeff


On Fri, Apr 13, 2018 at 4:31 PM, David Ahern <dsahern@gmail.com> wrote:
> On 4/13/18 2:23 PM, Jeff Barnhill wrote:
>> It seems that the ENETUNREACH response is still desirable in the VRF
>> case since the only difference (when using VRF vs. not) is that the
>> lookup should be restrained to a specific VRF.
>
> VRF is just policy routing to a table. If the table wants the lookup to
> stop, then it needs a default route. What you are referring to is the
> lookup goes through all tables and does not find an answer so it fails
> with -ENETUNREACH. I do not know of any way to make that happen with the
> existing default route options and in the past 2+ years we have not hit
> any s/w that discriminates -ENETUNREACH from -EHOSTUNREACH.
>
> I take it this is code from your internal code base. Why does it care
> between those two failures?

      reply	other threads:[~2018-04-14 22:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25 20:45 v6/sit tunnels and VRFs Jeff Barnhill
2017-10-25 21:31 ` David Ahern
2017-10-26  3:28   ` Jeff Barnhill
2017-10-26 17:24     ` David Ahern
2017-10-27  5:19       ` Jeff Barnhill
2017-10-27 16:25         ` David Ahern
2017-10-27 20:59           ` Jeff Barnhill
2017-10-27 22:53             ` David Ahern
2017-10-28  2:43               ` Jeff Barnhill
2017-10-29 15:48                 ` David Ahern
2017-10-31 22:20                   ` Jeff Barnhill
2017-10-31 22:36                     ` David Ahern
2017-10-31 22:42                     ` David Ahern
2018-04-12 16:54                   ` Jeff Barnhill
2018-04-13  2:25                     ` David Ahern
2018-04-13 20:23                       ` Jeff Barnhill
2018-04-13 20:31                         ` David Ahern
2018-04-14 22:07                           ` Jeff Barnhill [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL6e_pepzeTXMboH-OKGyfevoXFJWZThbT-qR8kx9vFXtmxm1Q@mail.gmail.com \
    --to=0xeffeff@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).