netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean-Michel Hautbois <jhautbois@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Sathya.Perla@emulex.com, netdev@vger.kernel.org
Subject: Re: Difficulties to get 1Gbps on be2net ethernet card
Date: Wed, 6 Jun 2012 15:07:46 +0200	[thread overview]
Message-ID: <CAL8zT=jGHo82mo-s8Tfs9LWzfu2GkrS4eZJoeOpHhpXHMr6csg@mail.gmail.com> (raw)
In-Reply-To: <CAL8zT=hHDPnvRFcQ0w+D=AP+QK6ic4X=tva6Yw_XGwuTbAYjhQ@mail.gmail.com>

2012/6/6 Jean-Michel Hautbois <jhautbois@gmail.com>:
> 2012/6/6 Eric Dumazet <eric.dumazet@gmail.com>:
>> On Wed, 2012-06-06 at 12:04 +0200, Jean-Michel Hautbois wrote:
>>
>>> Well, well, well, after having tested several configurations, several
>>> drivers, I have a big difference between an old 2.6.26 kernel and a
>>> newer one (I tried 3.2 and 3.4).
>>>
>>> Here is my stream : UDP packets (multicast), 4000 bytes length, MTU
>>> set to 4096. I am sending packets only, nothing on RX.
>>> I send from 1Gbps upto 2.4Gbps and I see no drops in tc with 2.6.26
>>> kernel, but a lot of drops with a newer kernel.
>>> So, I don't know if I missed something in my kernel configuration, but
>>> I have used the 2.6.26 one as a reference, in order to set the same
>>> options (DMA related, etc).
>>>
>>> I easily reproduce this problem and setting a bigger txqueuelen solves
>>> it partially.
>>> 1Gbps requires a txqueulen of 9000, 2.4Gbps requires more than 20000 !
>>>
>>> If you have any idea, I am interested, as this is a big issue for my use case.
>>>
>>
>> Yep.
>>
>> This driver wants to limit number of tx completions, thats just wrong.
>>
>> Fix and dirty patch:
>>
>>
>> diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
>> index c5c4c0e..1e8f8a6 100644
>> --- a/drivers/net/ethernet/emulex/benet/be.h
>> +++ b/drivers/net/ethernet/emulex/benet/be.h
>> @@ -105,7 +105,7 @@ static inline char *nic_name(struct pci_dev *pdev)
>>  #define MAX_TX_QS              8
>>  #define MAX_ROCE_EQS           5
>>  #define MAX_MSIX_VECTORS       (MAX_RSS_QS + MAX_ROCE_EQS) /* RSS qs + RoCE */
>> -#define BE_TX_BUDGET           256
>> +#define BE_TX_BUDGET           65535
>>  #define BE_NAPI_WEIGHT         64
>>  #define MAX_RX_POST            BE_NAPI_WEIGHT /* Frags posted at a time */
>>  #define RX_FRAGS_REFILL_WM     (RX_Q_LEN - MAX_RX_POST)
>>
>
> I will try that in a few minutes.
> I also have a mlx4 driver (mlx4_en) which has a similar behaviour, and
> a broadcom (bnx2x).
>

And it is not really better, still need about 18000 at 2.4Gbps in
order to avoid drops...
I really think there is something in the networking stack or in my
configuration (DMA ? Something else ?)...
As it doesn't seem to be driver related as I said...

JM

  reply	other threads:[~2012-06-06 13:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-29 14:46 Difficulties to get 1Gbps on be2net ethernet card Jean-Michel Hautbois
2012-05-30  6:28 ` Jean-Michel Hautbois
2012-05-30  6:48   ` Eric Dumazet
2012-05-30  6:51     ` Jean-Michel Hautbois
2012-05-30  7:06       ` Eric Dumazet
2012-05-30  7:25         ` Jean-Michel Hautbois
2012-05-30  9:40           ` Jean-Michel Hautbois
2012-05-30  9:56             ` Eric Dumazet
2012-05-30 10:06               ` Jean-Michel Hautbois
2012-05-30 10:04             ` Sathya.Perla
2012-05-30 10:07               ` Jean-Michel Hautbois
2012-06-06 10:04                 ` Jean-Michel Hautbois
2012-06-06 11:01                   ` Eric Dumazet
2012-06-06 12:34                     ` Jean-Michel Hautbois
2012-06-06 13:07                       ` Jean-Michel Hautbois [this message]
2012-06-06 14:36                         ` Jean-Michel Hautbois
2012-06-07 12:27                           ` Jean-Michel Hautbois
2012-06-07 12:31                             ` Eric Dumazet
2012-06-07 12:54                               ` Jean-Michel Hautbois
2012-06-08  6:08                                 ` Eric Dumazet
2012-06-08  8:14                                   ` Jean-Michel Hautbois
2012-06-08  8:22                                     ` Eric Dumazet
2012-06-08 14:53                                       ` Jean-Michel Hautbois
2012-06-12  8:24                                         ` Jean-Michel Hautbois
2012-06-12  8:55                                           ` Eric Dumazet
2012-06-12  9:01                                             ` Jean-Michel Hautbois
2012-06-12  9:06                                               ` Eric Dumazet
2012-06-12  9:10                                                 ` Jean-Michel Hautbois
2012-05-30 10:30               ` Eric Dumazet
2012-05-30 11:10                 ` Sathya.Perla
2012-05-31  6:54               ` Jean-Michel Hautbois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL8zT=jGHo82mo-s8Tfs9LWzfu2GkrS4eZJoeOpHhpXHMr6csg@mail.gmail.com' \
    --to=jhautbois@gmail.com \
    --cc=Sathya.Perla@emulex.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).