From: William Tu <u9012063@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: David Laight <David.Laight@aculab.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Xin Long <lucien.xin@gmail.com>
Subject: Re: [PATCH net-next] ip_gre: check packet length and mtu correctly in erspan_fb_xmit
Date: Fri, 6 Oct 2017 15:51:05 -0700 [thread overview]
Message-ID: <CALDO+SZCXUq_CSq_GRRQyBeVFWh1F-jBZDMyPsvcB-ghHbZSpQ@mail.gmail.com> (raw)
In-Reply-To: <20171006.232229.74190380417429379.davem@davemloft.net>
On Fri, Oct 6, 2017 at 3:22 PM, David Miller <davem@davemloft.net> wrote:
> From: William Tu <u9012063@gmail.com>
> Date: Fri, 6 Oct 2017 15:09:29 -0700
>
>> Yes, adding another field in the struct net_device can avoid the
>> arithmetic operation. I'm not sure it's a good idea to add new field
>> since there are already a lot in net_device. Let's wait to see how
>> others think.
>
> Why would you add it to net_device when you can add it to ip_tunnel?
>
I see. I will add it to ip_tunnel and resubmit the patch. Thanks!
prev parent reply other threads:[~2017-10-06 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 0:14 [PATCH net-next] ip_gre: check packet length and mtu correctly in erspan_fb_xmit William Tu
2017-10-05 13:59 ` David Laight
2017-10-05 21:20 ` William Tu
2017-10-06 9:38 ` David Laight
2017-10-06 22:09 ` William Tu
2017-10-06 22:22 ` David Miller
2017-10-06 22:51 ` William Tu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDO+SZCXUq_CSq_GRRQyBeVFWh1F-jBZDMyPsvcB-ghHbZSpQ@mail.gmail.com \
--to=u9012063@gmail.com \
--cc=David.Laight@aculab.com \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).