From: sundeep subbaraya <sundeep.lkml@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Subbaraya Sundeep <sbhatta@marvell.com>,
David Miller <davem@davemloft.net>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, sgoutham@marvell.com,
Aleksey Makarov <amakarov@marvell.com>
Subject: Re: [PATCH v4 net-next 3/3] octeontx2-pf: Add support for PTP clock
Date: Fri, 17 Jul 2020 10:41:49 +0530 [thread overview]
Message-ID: <CALHRZupxX5Cbvb03s-xxA7gobjwo8cM7n4_-U6oGysU3R18-Bw@mail.gmail.com> (raw)
In-Reply-To: <20200716171109.7d8c6d17@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hi Jakub,
On Fri, Jul 17, 2020 at 5:41 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 15 Jul 2020 18:08:09 +0530 Subbaraya Sundeep wrote:
> > @@ -1730,10 +1745,149 @@ static void otx2_reset_task(struct work_struct *work)
> > if (!netif_running(pf->netdev))
> > return;
> >
> > + rtnl_lock();
> > otx2_stop(pf->netdev);
> > pf->reset_count++;
> > otx2_open(pf->netdev);
> > netif_trans_update(pf->netdev);
> > + rtnl_unlock();
> > +}
> > +
>
> This looks unrelated, otherwise for the patches:
You mean the lock/unlock logic with this patch?
I can separate this out and put in another patch #4 if you insist.
Thanks,
Sundeep
>
> Acked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2020-07-17 5:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 12:38 [PATCH v4 net-next 0/3] Add PTP support for Octeontx2 Subbaraya Sundeep
2020-07-15 12:38 ` [PATCH v4 net-next 1/3] octeontx2-af: Support to enable/disable HW timestamping Subbaraya Sundeep
2020-07-15 12:38 ` [PATCH v4 net-next 2/3] octeontx2-af: Add support for Marvell PTP coprocessor Subbaraya Sundeep
2020-07-15 12:38 ` [PATCH v4 net-next 3/3] octeontx2-pf: Add support for PTP clock Subbaraya Sundeep
2020-07-17 0:11 ` Jakub Kicinski
2020-07-17 5:11 ` sundeep subbaraya [this message]
2020-07-17 17:48 ` Jakub Kicinski
2020-07-17 18:02 ` David Miller
2020-07-18 12:54 ` sundeep subbaraya
2020-07-18 12:53 ` sundeep subbaraya
2020-07-15 13:20 ` [PATCH v4 net-next 0/3] Add PTP support for Octeontx2 Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALHRZupxX5Cbvb03s-xxA7gobjwo8cM7n4_-U6oGysU3R18-Bw@mail.gmail.com \
--to=sundeep.lkml@gmail.com \
--cc=amakarov@marvell.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).