* [PATCH v2] ath6kl: mark expected switch fall-throughs
@ 2018-05-25 18:23 Gustavo A. R. Silva
2018-05-25 18:27 ` Steve deRosier
2018-06-13 11:44 ` [v2] " Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2018-05-25 18:23 UTC (permalink / raw)
To: Kalle Valo, David S. Miller, Sergei Shtylyov
Cc: linux-wireless, netdev, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
Changes in v2:
- Place code comments on a line of their own.
drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 2ba8cf3..a16ee5d 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -3899,16 +3899,19 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
switch (ar->hw.cap) {
case WMI_11AN_CAP:
ht = true;
+ /* fall through */
case WMI_11A_CAP:
band_5gig = true;
break;
case WMI_11GN_CAP:
ht = true;
+ /* fall through */
case WMI_11G_CAP:
band_2gig = true;
break;
case WMI_11AGN_CAP:
ht = true;
+ /* fall through */
case WMI_11AG_CAP:
band_2gig = true;
band_5gig = true;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] ath6kl: mark expected switch fall-throughs
2018-05-25 18:23 [PATCH v2] ath6kl: mark expected switch fall-throughs Gustavo A. R. Silva
@ 2018-05-25 18:27 ` Steve deRosier
2018-05-25 18:48 ` Gustavo A. R. Silva
2018-06-13 11:44 ` [v2] " Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Steve deRosier @ 2018-05-25 18:27 UTC (permalink / raw)
To: gustavo
Cc: Kalle Valo, davem, sergei.shtylyov, linux-wireless,
Network Development, LKML
On Fri, May 25, 2018 at 11:23 AM Gustavo A. R. Silva
<gustavo@embeddedor.com>
wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> Changes in v2:
> - Place code comments on a line of their own.
> drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c
b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> index 2ba8cf3..a16ee5d 100644
> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> @@ -3899,16 +3899,19 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
> switch (ar->hw.cap) {
> case WMI_11AN_CAP:
> ht = true;
> + /* fall through */
> case WMI_11A_CAP:
> band_5gig = true;
> break;
> case WMI_11GN_CAP:
> ht = true;
> + /* fall through */
> case WMI_11G_CAP:
> band_2gig = true;
> break;
> case WMI_11AGN_CAP:
> ht = true;
> + /* fall through */
> case WMI_11AG_CAP:
> band_2gig = true;
> band_5gig = true;
> --
> 2.7.4
Gustavo,
Thanks for the adjustment. It now looks good to me.
Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] ath6kl: mark expected switch fall-throughs
2018-05-25 18:27 ` Steve deRosier
@ 2018-05-25 18:48 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2018-05-25 18:48 UTC (permalink / raw)
To: Steve deRosier
Cc: Kalle Valo, davem, sergei.shtylyov, linux-wireless,
Network Development, LKML
On 05/25/2018 01:27 PM, Steve deRosier wrote:
> On Fri, May 25, 2018 at 11:23 AM Gustavo A. R. Silva
> <gustavo@embeddedor.com>
> wrote:
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> Changes in v2:
>> - Place code comments on a line of their own.
>
>> drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 +++
>> 1 file changed, 3 insertions(+)
>
>> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> b/drivers/net/wireless/ath/ath6kl/cfg80211.c
>> index 2ba8cf3..a16ee5d 100644
>> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
>> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
>> @@ -3899,16 +3899,19 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
>> switch (ar->hw.cap) {
>> case WMI_11AN_CAP:
>> ht = true;
>> + /* fall through */
>> case WMI_11A_CAP:
>> band_5gig = true;
>> break;
>> case WMI_11GN_CAP:
>> ht = true;
>> + /* fall through */
>> case WMI_11G_CAP:
>> band_2gig = true;
>> break;
>> case WMI_11AGN_CAP:
>> ht = true;
>> + /* fall through */
>> case WMI_11AG_CAP:
>> band_2gig = true;
>> band_5gig = true;
>> --
>> 2.7.4
>
>
> Gustavo,
>
> Thanks for the adjustment. It now looks good to me.
>
Glad to help. :)
> Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
>
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v2] ath6kl: mark expected switch fall-throughs
2018-05-25 18:23 [PATCH v2] ath6kl: mark expected switch fall-throughs Gustavo A. R. Silva
2018-05-25 18:27 ` Steve deRosier
@ 2018-06-13 11:44 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2018-06-13 11:44 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Kalle Valo, David S. Miller, Sergei Shtylyov, linux-wireless,
netdev, linux-kernel, Gustavo A. R. Silva
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
4de30c906ef0 ath6kl: mark expected switch fall-throughs
--
https://patchwork.kernel.org/patch/10428239/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-13 11:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-25 18:23 [PATCH v2] ath6kl: mark expected switch fall-throughs Gustavo A. R. Silva
2018-05-25 18:27 ` Steve deRosier
2018-05-25 18:48 ` Gustavo A. R. Silva
2018-06-13 11:44 ` [v2] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).