From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA14AC43613 for ; Wed, 19 Jun 2019 20:44:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D1F021721 for ; Wed, 19 Jun 2019 20:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560977069; bh=PtdbT4+WZVrSzw4byKsl98ZDeoGvcEoZe9NmCjzp7NY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ZDTfLJSzB5tfNUKsJGBL6J2xoqnygu4NFy1WzFVuKt49UkJaIMyEiYCiprTvCe/3r OJg/Ud3WwNdsiRS6hFnoMODBXzWpoC1rR4JJVZIZ1tny4muMEHNF7UfQBUAln/J4wQ eRRkMCvysifSBqsX8ADNGXRRuk19kk0RP7Yhgl0A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730014AbfFSUo2 (ORCPT ); Wed, 19 Jun 2019 16:44:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:52020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726230AbfFSUo2 (ORCPT ); Wed, 19 Jun 2019 16:44:28 -0400 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB8142177E; Wed, 19 Jun 2019 20:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560977066; bh=PtdbT4+WZVrSzw4byKsl98ZDeoGvcEoZe9NmCjzp7NY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=SmxtmjKiyfEWKKyjPAThNkWlA5SttyK01pMv/kTD8l61XVCe/7BjNti98SwgjiM/T Q/ahTcG4e9SA1rQsFe1ZB5NVqF2LhqmjCO1o/p9OPoT0RoY5z/E168ZjUBv83d197K Ta3vGJjMlOIct4TbSa/GiCtdVq8NU897XITaTlQ4= Received: by mail-qt1-f174.google.com with SMTP id y57so719523qtk.4; Wed, 19 Jun 2019 13:44:26 -0700 (PDT) X-Gm-Message-State: APjAAAWIeCtW76D5IbAq0mpiKEUtNegXNfabI339J5hwdn9MjLSxtjW4 /IKuRmVA+CVnBUE3U6eba0FOrm8CuOPHvEkzrw== X-Google-Smtp-Source: APXvYqyVAwxgOJDLFwnKUkBgoRpv1RMyh0FtU2bURQqffQhs//0pjSXX6+r6qT6fEnddczKAAfSd98UZabnH3BaOarM= X-Received: by 2002:ac8:3908:: with SMTP id s8mr106885352qtb.224.1560977065877; Wed, 19 Jun 2019 13:44:25 -0700 (PDT) MIME-Version: 1.0 References: <27aeb33cf5b896900d5d11bd6957eda268014f0c.1560937626.git-series.maxime.ripard@bootlin.com> In-Reply-To: From: Rob Herring Date: Wed, 19 Jun 2019 14:44:13 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 06/16] dt-bindings: net: sun4i-emac: Convert the binding to a schemas To: Maxime Ripard Cc: Mark Rutland , Frank Rowand , "David S . Miller" , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , netdev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier , =?UTF-8?Q?Antoine_T=C3=A9nart?= , Andrew Lunn , Florian Fainelli , Heiner Kallweit Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jun 19, 2019 at 8:46 AM Rob Herring wrote: > > On Wed, Jun 19, 2019 at 3:48 AM Maxime Ripard wrote: > > > > Switch our Allwinner A10 EMAC controller binding to a YAML schema to enable > > the DT validation. > > > > Signed-off-by: Maxime Ripard > > > > --- > > > > Changes from v2: > > - Switch from the deprecated phy property to phy-handle > > --- > > Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > Documentation/devicetree/bindings/net/allwinner,sun4i-emac.txt | 19 ------------------- > > 2 files changed, 55 insertions(+), 19 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml > > delete mode 100644 Documentation/devicetree/bindings/net/allwinner,sun4i-emac.txt > > > > diff --git a/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml > > new file mode 100644 > > index 000000000000..2ff9e605cd26 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml > > @@ -0,0 +1,55 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/allwinner,sun4i-a10-emac.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Allwinner A10 EMAC Ethernet Controller Device Tree Bindings > > + > > +allOf: > > + - $ref: "ethernet-controller.yaml#" > > + > > +maintainers: > > + - Chen-Yu Tsai > > + - Maxime Ripard > > + > > +properties: > > + compatible: > > + const: allwinner,sun4i-a10-emac > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + allwinner,sram: > > + description: Phandle to the device SRAM > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - phy-handle > > Doesn't this throw an error if not listed in properties? NM, it doesn't. Reviewed-by: Rob Herring Rob