From: Pravin Shelar <pshelar@nicira.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jesse Gross <jesse@nicira.com>
Subject: Re: [PATCH 2/2] genl: Hold reference on correct module while netlink-dump.
Date: Fri, 23 Aug 2013 10:05:52 -0700 [thread overview]
Message-ID: <CALnjE+o1SNmsDHACayosU8AwEekdcc-6WNdvtgSun01FTvdn6g@mail.gmail.com> (raw)
In-Reply-To: <1377242625.14021.5.camel@jlt4.sipsolutions.net>
On Fri, Aug 23, 2013 at 12:23 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
>
>> +extern int __genl_register_family(struct genl_family *family, struct module *module);
>
> Why add an extra argument instead of just assigning family->module in
> the inline wrapper(s):
>
> static inline int genl_register_family(struct genl_family *family)
> {
> family->module = THIS_MODULE;
> return __genl_register_family(family);
> }
>
This is better, I will send updated patch.
next prev parent reply other threads:[~2013-08-23 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 21:25 [PATCH 2/2] genl: Hold reference on correct module while netlink-dump Pravin B Shelar
2013-08-23 7:23 ` Johannes Berg
2013-08-23 17:05 ` Pravin Shelar [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-22 3:58 Pravin B Shelar
2013-08-22 7:40 ` Johannes Berg
2013-08-22 17:44 ` Pravin Shelar
2013-08-22 17:49 ` Johannes Berg
2013-08-22 18:04 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALnjE+o1SNmsDHACayosU8AwEekdcc-6WNdvtgSun01FTvdn6g@mail.gmail.com \
--to=pshelar@nicira.com \
--cc=jesse@nicira.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).