From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pravin Shelar Subject: Re: [PATCH net v2] openvswitch: Fix mask generation for nested attributes. Date: Sat, 12 Sep 2015 17:04:35 -0700 Message-ID: References: <1442021908-47034-1-git-send-email-jesse@nicira.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: David Miller , netdev To: Jesse Gross Return-path: Received: from mail-io0-f175.google.com ([209.85.223.175]:32985 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441AbbIMAEg (ORCPT ); Sat, 12 Sep 2015 20:04:36 -0400 Received: by iofh134 with SMTP id h134so133325056iof.0 for ; Sat, 12 Sep 2015 17:04:35 -0700 (PDT) In-Reply-To: <1442021908-47034-1-git-send-email-jesse@nicira.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Sep 11, 2015 at 6:38 PM, Jesse Gross wrote: > Masks were added to OVS flows in a way that was backwards compatible > with userspace programs that did not generate masks. As a result, it is > possible that we may receive flows that do not have a mask and we need > to synthesize one. > > Generating a mask requires iterating over attributes and descending into > nested attributes. For each level we need to know the size to generate the > correct mask. We do this with a linked table of attribute types. > > Although the logic to handle these nested attributes was there in concept, > there are a number of bugs in practice. Examples include incomplete links > between tables, variable length attributes being treated as nested and > missing sanity checks. > > Signed-off-by: Jesse Gross Thanks for the fix. Acked-by: Pravin B Shelar