From: Pravin Shelar <pshelar@nicira.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2 net-next] ip_tunnel: operstate support and link state transfer
Date: Tue, 6 Aug 2013 11:07:06 -0700 [thread overview]
Message-ID: <CALnjE+p_rSYZSgrT=P2B5XJebJ4_i6UKKo_8gyD1EoNG_1ve7w@mail.gmail.com> (raw)
In-Reply-To: <20130806104942.25bdcfa1@nehalam.linuxnetplumber.net>
On Tue, Aug 6, 2013 at 10:49 AM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Tue, 6 Aug 2013 10:42:53 -0700
> Pravin Shelar <pshelar@nicira.com> wrote:
>
>> On Mon, Aug 5, 2013 at 10:53 PM, Stephen Hemminger
>> <stephen@networkplumber.org> wrote:
>> > Tunnel devices should reflect the carrier state of the lower device.
>> > I.e if carrier goes down on the lower (ethernet) device, it should
>> > change on the tunnel as well.
>> >
>> > This patch also adds full RFC2863 compatible state so that the
>> > tunnel state can be controlled from user space as described in
>> > Documentation/networking/operstats.txt
>> >
>> > Example of usage:
>> > ip li add tnl1 mode dormant \
>> > type gretap remote 172.19.20.21 local 172.16.17.18 dev eth1
>> > ip li set dev tnl1 up
>> > ip li set dev tnl1 state UP
>> >
>> > In real life, this would be managed by tunnel broker, not
>> > iproute2 shell commands.
>> >
>> >
>> I sent out similar patch which try to add this feature at ip_tunnel
>> generic layer rather than in tunnel implementation. This way we can
>> share single notifier for all tunneling protocols.
>> Can you have something similar?
>> http://marc.info/?l=linux-netdev&m=135761231222711&w=2
>
> How does that work well for case of GRE where gre and gretap
> have different net namespace id's. If it can handle that, then
> this is better.
>
ip_tunnel registers its own net namespace struct to keep track of all
tunnels from different tunneling protocols.
> Also link_map could be array (not allocated), and avoid
> another layer of indirection
>
> Also, the rfc2863 policy needs to handle CHANGE (for carrier).
that event is not handled in the patch.
next prev parent reply other threads:[~2013-08-06 18:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 5:51 [PATCH net-next 1/2] ip_tunnel: embed hash list head Stephen Hemminger
2013-08-06 5:53 ` [PATCH 2/2 net-next] ip_tunnel: operstate support and link state transfer Stephen Hemminger
2013-08-06 17:42 ` Pravin Shelar
2013-08-06 17:49 ` Stephen Hemminger
2013-08-06 18:07 ` Pravin Shelar [this message]
2013-08-06 23:44 ` [RFC] ip_tunnel: follow lower device state Stephen Hemminger
2013-08-06 17:41 ` [PATCH net-next 1/2] ip_tunnel: embed hash list head Pravin Shelar
2013-08-07 23:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALnjE+p_rSYZSgrT=P2B5XJebJ4_i6UKKo_8gyD1EoNG_1ve7w@mail.gmail.com' \
--to=pshelar@nicira.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).