From: Pravin Shelar <pshelar@nicira.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull
Date: Mon, 31 Aug 2015 20:29:02 -0700 [thread overview]
Message-ID: <CALnjE+pri5SDS5nPyhdwgki4N-eOF0TuWWigiAhx2gCznqYOmw@mail.gmail.com> (raw)
In-Reply-To: <20150901014022.GA11983@Alexeis-MacBook-Pro-2.local>
On Mon, Aug 31, 2015 at 6:40 PM, Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
> On Mon, Aug 31, 2015 at 03:55:46PM -0700, Pravin B Shelar wrote:
>> VXLAN device can receive skb with checksum partial. But the checksum
>> offset could be in outer header which is pulled on receive. Such skb
>> can cause the panic when checksum is calculated on skb. Following patch
>> fixes the bug by setting checksum unnecessary while pulling outer header.
>>
>> ---8<---
>> [ 13.800141] RIP: 0010:[<ffffffff81518034>] [<ffffffff81518034>] skb_checksum_help+0x144/0x150
>> [ 13.800141] RSP: 0000:ffff88011fd83940 EFLAGS: 00010292
>> [ 13.800141] RAX: 0000000000000042 RBX: ffff880114dd56c0 RCX: ffff8801188d9580
>> ...
>> ...
>> [ 13.852308] Call Trace:
>> [ 13.852308] <IRQ>
>> [ 13.852308] [<ffffffffa0164c28>] queue_userspace_packet+0x408/0x470 [openvswitch]
>> [ 13.852308] [<ffffffffa016614d>] ovs_dp_upcall+0x5d/0x60 [openvswitch]
>> [ 13.852308] [<ffffffffa0166236>] ovs_dp_process_packet_with_key+0xe6/0x100 [openvswitch]
>> [ 13.852308] [<ffffffffa016629b>] ovs_dp_process_received_packet+0x4b/0x80 [openvswitch]
>
> that doesn't look like upstream kernel.
> The above two functions don't exist in net-next.
>
Bug was reported on older kernel. But the issue exist on net-next
kernel. For example when vxlan checksum is turned on.
next prev parent reply other threads:[~2015-09-01 3:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 22:55 [PATCH net] skbuff: Fix skb checksum flag on skb pull Pravin B Shelar
2015-08-31 23:44 ` Tom Herbert
2015-09-01 3:25 ` Pravin Shelar
2015-09-01 3:48 ` Tom Herbert
2015-09-01 1:40 ` Alexei Starovoitov
2015-09-01 3:29 ` Pravin Shelar [this message]
2015-09-01 4:12 ` Tom Herbert
2015-09-01 5:15 ` Pravin Shelar
2015-09-01 14:19 ` Tom Herbert
2015-09-01 19:20 ` Pravin Shelar
2015-09-01 19:55 ` Tom Herbert
2015-09-01 21:10 ` Pravin Shelar
2015-09-01 21:25 ` Tom Herbert
2015-09-01 23:37 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALnjE+pri5SDS5nPyhdwgki4N-eOF0TuWWigiAhx2gCznqYOmw@mail.gmail.com \
--to=pshelar@nicira.com \
--cc=alexei.starovoitov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).